feat: show addon icon from manifest#22
Merged
jmaxdev merged 4 commits intoTrixtyAI:mainfrom Apr 19, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for showing an addon-provided icon from the addon manifest in the marketplace UI, falling back to the existing generic Package icon when not available or when loading fails.
Changes:
- Extends
ExtensionManifestwith an optionalicon?: stringfield. - Introduces
resolveIconUrl()+AddonIconinMarketplaceViewto render either a manifest-provided icon (absolute URL or repo-relative path) or aPackagefallback. - Updates both the marketplace grid cards and the details header to use
AddonIconwithoverflow-hiddenwrappers for proper rounding.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| apps/desktop/src/context/ExtensionContext.tsx | Adds icon?: string to the manifest type so addon metadata can include an icon path/URL. |
| apps/desktop/src/components/MarketplaceView.tsx | Resolves icon URLs (absolute or GitHub-raw relative) and renders them with graceful fallback in grid + details views. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # apps/desktop/src/components/MarketplaceView.tsx
Collaborator
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for an
iconfield in the addon manifest so marketplace entries can display their own logo instead of the genericPackagefallback.apps/desktop/src/context/ExtensionContext.tsx: adds optionalicon?: stringtoExtensionManifest.apps/desktop/src/components/MarketplaceView.tsx: adds a smallresolveIconUrl()helper that accepts either an absolute URL or a path relative to the addon's repo (resolved againstraw.githubusercontent.comusing the same owner/branch/path logic asrepo_to_raw_baseon the Rust side). Adds anAddonIconcomponent that renders the image and falls back to the existingPackageicon when there's no icon or when the image fails to load. Both usages (grid card and details view header) now go through it, withoverflow-hiddenon the wrappers so the image respects the rounded corners.Addons can now declare any of:
{ "icon": "assets/logo.png" } { "icon": "https://example.com/logo.svg" }Entries without an
iconkeep the current visual unchanged.Issues