Potential fix for code scanning alert no. 1: Bad HTML filtering regexp#36
Merged
Potential fix for code scanning alert no. 1: Bad HTML filtering regexp#36
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/TrixtyAI/ide/security/code-scanning/1
General fix: update the HTML comment end-tag regex to accept both standard and permissive parser-accepted forms.
Best fix here: in
apps/desktop/src/addons/builtin.language.html/index.ts, in thecommenttokenizer state, replace the terminator regex from-->/to a pattern that matches both-->and--!>, i.e./--!?\>/(or equivalent). This preserves existing behavior while adding the missing valid terminator variant.Only one code region needs to change:
tokenizer.commentrule (currently line 40 in provided snippet).No new imports, methods, or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.