Potential fix for code scanning alert no. 3: Inefficient regular expression#38
Merged
Potential fix for code scanning alert no. 3: Inefficient regular expression#38
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jmaxdev
force-pushed
the
alert-autofix-3
branch
from
2e38cd0 to
224102e
Compare
…ession Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
jmaxdev
force-pushed
the
alert-autofix-3
branch
from
6e95e0a to
f50ead8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/TrixtyAI/ide/security/code-scanning/3
To fix this safely, make the repeated alternatives mutually exclusive so the engine has a single clear way to consume input.
Best fix in this file: rewrite line 84’s inner group to consume either:
@escapes), or[^\\_]), or_(?!_)).Putting
@escapesfirst and keeping the other branches disjoint removes the ambiguous overlap under+while preserving intended markdown bold-underscore matching behavior.Change only this regex in
apps/desktop/src/addons/builtin.language.markdown/index.tsintokenizer.linecontent.Suggested fixes powered by Copilot Autofix. Review carefully before merging.