Skip to content

chore(http): remove subscriptions replay endpoint#159

Merged
yordis merged 2 commits intomasterfrom
yordis/chore-remove-subscriptions-replay-http
May 3, 2026
Merged

chore(http): remove subscriptions replay endpoint#159
yordis merged 2 commits intomasterfrom
yordis/chore-remove-subscriptions-replay-http

Conversation

@yordis
Copy link
Copy Markdown
Member

@yordis yordis commented May 3, 2026

  • Persistent subscription parked-message replay already has a gRPC management path, so keeping the HTTP command route preserves duplicate control surfaces without adding capability.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented May 3, 2026

PR Summary

Medium Risk
Removes a public HTTP management endpoint and its discoverability links, which is a breaking API change for any clients still using the HTTP replay workflow. Logic deletion is localized, but downstream tooling and automation may fail until migrated to gRPC.

Overview
Removes the persistent subscription HTTP command route for replaying parked messages (the POST /subscriptions/{stream}/{subscription}/replayParked endpoint), including the handler logic and related URL/operation wiring in PersistentSubscriptionController.

Updates HTTP subscription stats responses and tests to only expose a single detail link, and removes the endpoint from authorization route tests and the generated swagger.yaml.

Reviewed by Cursor Bugbot for commit a0f5564. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

Warning

Rate limit exceeded

@yordis has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 28 minutes and 37 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f3c94f90-78d2-425f-b925-220cea43eaf7

📥 Commits

Reviewing files that changed from the base of the PR and between c67fc3f and a0f5564.

📒 Files selected for processing (1)
  • src/EventStore.Core.Tests/Http/PersistentSubscription/statistics.cs

Walkthrough

This PR removes the HTTP endpoint for replaying parked persistent-subscription messages (POST /subscriptions/{stream}/{subscription}/replayParked), including its route handler, parameter binding, error helpers, API documentation, and authorization test coverage. The subscription detail DTO no longer includes a rellink to this endpoint.

Changes

Replay Parked Messages Endpoint Removal

Layer / File(s) Summary
Core Implementation
src/EventStore.Core/Services/Transport/Http/Controllers/PersistentSubscriptionController.cs
Removed route registration for POST /subscriptions/{stream}/{subscription}/replayParked, deleted ReplayParkedMessages() handler and parameter binding helper, removed unused error-envelope utilities, and removed replayParked rellink from subscription detail DTO.
API Contract
src/EventStore.Core.Tests/swagger.yaml
POST /subscriptions/{stream}/{subscription}/replayParked endpoint and its response definition removed from OpenAPI spec.
Authorization Tests
src/EventStore.Core.Tests/Services/Transport/Http/Authorization/authorization_tests.cs
Test matrix updated to replace replayParked POST entry with POST and DELETE cases for /subscriptions/{stream}/{subscription} and GET case for /subscriptions/{stream}/{subscription}/info.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes


🐰 A parked endpoint hops away,
No more replaying the day,
Links trimmed clean, tests made right,
The persistent path shines bright! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removal of the HTTP subscriptions replay endpoint, which aligns with all three modified files.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for removing the HTTP replay endpoint and referencing the existing gRPC alternative.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/chore-remove-subscriptions-replay-http

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 28 minutes and 37 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis merged commit 065b21a into master May 3, 2026
18 checks passed
@yordis yordis deleted the yordis/chore-remove-subscriptions-replay-http branch May 3, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant