chore(http): reduce duplicate subscription commands#160
Conversation
yordis
commented
May 3, 2026
- Persistent subscription deletion already has a gRPC management path, so retaining the HTTP command route keeps duplicate write surfaces alive without preserving unique capability.
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryMedium Risk Overview Updates HTTP authorization tests and the Swagger spec to no longer reference that delete route, and replaces the removed HTTP deletion tests with new gRPC management tests that validate delete success, permission-denied behavior, not-found handling, and subscriber cancellation. Reviewed by Cursor Bugbot for commit 111e046. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fbc08b0. Configure here.
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
