Skip to content

fix(trogonstack-datadog): add B trap guide and platform metric catalog#38

Merged
yordis merged 1 commit intomainfrom
docs/datadog-dashboard-b-trap-and-classification-guide
Apr 9, 2026
Merged

fix(trogonstack-datadog): add B trap guide and platform metric catalog#38
yordis merged 1 commit intomainfrom
docs/datadog-dashboard-b-trap-and-classification-guide

Conversation

@yordis
Copy link
Copy Markdown
Member

@yordis yordis commented Apr 9, 2026

  • Transport-layer metrics (gRPC error rate, HTTP request rate, apdex) are consistently misclassified as Business (B) group widgets; adding an explicit gate and B trap check to the skill prevents this before the dashboard is built
  • A Platform metric catalog documents how to classify metrics from common infrastructure patterns (inbound servers, outbound clients, job queues, event-driven systems) so the skill has a reference to apply rather than re-derive per session
  • Anti-patterns in layouts.md cover domain-specific filter leakage into platform groups and redundant per-handler widgets, both of which surface as real noise in designed dashboards
  • list_stream widget documentation clarifies the trace_stream query schema to prevent 400 validation errors from unsupported fields

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 9, 2026

PR Summary

Low Risk
Low risk: documentation-only changes to the dashboard design skill and reference guides; no runtime code paths or APIs are modified.

Overview
Adds stronger guardrails to prevent misclassifying transport-layer signals as Business metrics: introduces a domain-outcome gate before designing the B group and adds an explicit B-trap check during audits.

Expands the references with (1) a new list_stream section clarifying trace_stream query schema limitations to avoid Datadog API validation errors, (2) a platform metric catalog to guide I/P/D/B classification, and (3) additional layout anti-patterns around domain-specific filtering in platform groups and redundant per-handler/worker widgets.

Reviewed by Cursor Bugbot for commit 909a6a6. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3b356c52-f721-4e09-a98b-51a152d843ac

📥 Commits

Reviewing files that changed from the base of the PR and between 5ee35ad and 909a6a6.

📒 Files selected for processing (3)
  • plugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.md
  • plugins/trogonstack-datadog/skills/datadog-design-dashboard/references/layouts.md
  • plugins/trogonstack-datadog/skills/datadog-design-dashboard/references/widgets.md

Walkthrough

Documentation updates to the Datadog dashboard design skill extend guidance with Design workflow gating requirements, telemetry verification clarification, anti-patterns for scope management, and expanded widget reference documentation including List Stream widget support and business-versus-platform metric classification rules.

Changes

Cohort / File(s) Summary
Core Design Documentation
plugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.md
Added explicit gating requirements for Business group design (service-specific domain outcomes required) and expanded telemetry exploration guidance with verification constraints across metric queries, APM filters, and log filters. Enhanced Audit checklist with "B trap check" to validate Business-group widget interpretability.
Reference Documentation
plugins/trogonstack-datadog/skills/datadog-design-dashboard/references/layouts.md, references/widgets.md
Added anti-patterns guidance for platform/domain group scoping and hardcoded filtering; extended widget title prefix system documentation with business-versus-platform metric classification rules and misclassification examples; added List Stream widget reference section with schema constraints and new platform metric catalog by component type.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Poem

🐰 Dashboard designs now shine so bright,
With gating rules and trapcheck might,
Business metrics sorted clean,
Anti-patterns now foreseen,
Documentation takes its flight! ✨📊

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/datadog-dashboard-b-trap-and-classification-guide

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis force-pushed the docs/datadog-dashboard-b-trap-and-classification-guide branch from d61313d to 909a6a6 Compare April 9, 2026 19:08
@yordis yordis changed the title docs(trogonstack-datadog): add B trap guide and platform metric catalog fix(trogonstack-datadog): add B trap guide and platform metric catalog Apr 9, 2026
@yordis yordis merged commit 1faf2a1 into main Apr 9, 2026
4 of 5 checks passed
@yordis yordis deleted the docs/datadog-dashboard-b-trap-and-classification-guide branch April 9, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant