Conversation
PR SummaryLow Risk Overview Significantly expands Refines guidance in Written by Cursor Bugbot for commit 84a2701. This will update automatically on new commits. Configure here. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdated the trogonstack-datadog plugin docs and workflows: broadened scope to "designing and reviewing" dashboards, added telemetry discovery steps, tightened naming/templating/query-scoping rules, removed separate dashboard-URL steps, and added widget/threshold reference documents for reviews. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 4❌ Failed checks (4 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/trogonstack-datadog/skills/datadog-name-dashboard/SKILL.md`:
- Line 10: The SKILL.md allowed-tools list doesn't include file edit
capabilities required to rename the JSON title; update the allowed-tools entry
in SKILL.md to include Read and Write (in addition to AskUserQuestion and Shell)
so the skill can read and modify files programmatically—specifically edit the
"allowed-tools" line to contain AskUserQuestion, Shell, Read, Write to enable
the documented JSON title update flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2f580255-cbc7-4b19-803f-eac837af080f
📒 Files selected for processing (3)
plugins/trogonstack-datadog/README.mdplugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.mdplugins/trogonstack-datadog/skills/datadog-name-dashboard/SKILL.md
plugins/trogonstack-datadog/skills/datadog-name-dashboard/SKILL.md
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
plugins/trogonstack-datadog/skills/datadog-name-dashboard/SKILL.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
plugins/trogonstack-datadog/skills/datadog-register-dashboard/SKILL.md (1)
35-37: Use explicit grouping in thefindexpression for clarityThis is easier to reason about and avoids precedence ambiguity in shell examples.
Suggested doc fix
-find . -name "service.datadog.yaml" -o -name "entity.datadog.yaml" | head -5 +find . \( -name "service.datadog.yaml" -o -name "entity.datadog.yaml" \) | head -5🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/trogonstack-datadog/skills/datadog-register-dashboard/SKILL.md` around lines 35 - 37, Update the find expression in SKILL.md where the snippet uses find . -name "service.datadog.yaml" -o -name "entity.datadog.yaml" to use explicit grouping: wrap the two -name tests in escaped parentheses ( \( ... \) ) so the -o applies only between those tests, keeping the rest of the pipeline (| head -5) unchanged; edit the snippet in SKILL.md to replace the ungrouped expression with the parenthesized form.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/trogonstack-datadog/skills/datadog-register-dashboard/SKILL.md`:
- Around line 146-149: The example validation command currently hardcodes the
service token "payment" in the pipeline check (the line containing `pup
dashboards list --yes | grep payment`); make it service-agnostic by replacing
the hardcoded token with a placeholder (e.g., `<SERVICE_NAME>` or an env var
like `$SERVICE_NAME`) and update the example text to instruct users to
substitute their service token when running the command so the skill remains
reusable across services.
---
Nitpick comments:
In `@plugins/trogonstack-datadog/skills/datadog-register-dashboard/SKILL.md`:
- Around line 35-37: Update the find expression in SKILL.md where the snippet
uses find . -name "service.datadog.yaml" -o -name "entity.datadog.yaml" to use
explicit grouping: wrap the two -name tests in escaped parentheses ( \( ... \) )
so the -o applies only between those tests, keeping the rest of the pipeline (|
head -5) unchanged; edit the snippet in SKILL.md to replace the ungrouped
expression with the parenthesized form.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cd5a82e1-e0a4-4f45-808b-1c774bf2ea0a
📒 Files selected for processing (4)
plugins/trogonstack-datadog/.claude-plugin/plugin.jsonplugins/trogonstack-datadog/README.mdplugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.mdplugins/trogonstack-datadog/skills/datadog-register-dashboard/SKILL.md
✅ Files skipped from review due to trivial changes (2)
- plugins/trogonstack-datadog/README.md
- plugins/trogonstack-datadog/.claude-plugin/plugin.json
🚧 Files skipped from review as they are similar to previous changes (1)
- plugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.md
plugins/trogonstack-datadog/skills/datadog-register-dashboard/SKILL.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
plugins/trogonstack-datadog/skills/datadog-register-dashboard/SKILL.md (2)
16-16: Consider simplifying "outside of" to "outside".Minor style suggestion: "invisible outside manually scrolling the list" is more concise than "invisible outside of manually scrolling the list".
✏️ Suggested edit
-A well-titled dashboard with no tags is invisible outside of manually scrolling the list. +A well-titled dashboard with no tags is invisible outside manually scrolling the list.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/trogonstack-datadog/skills/datadog-register-dashboard/SKILL.md` at line 16, The sentence "A well-titled dashboard with no tags is invisible outside of manually scrolling the list." should be edited for concision; replace "invisible outside of manually scrolling the list" with "invisible outside manually scrolling the list" in SKILL.md (edit the sentence that begins "A well-titled dashboard with no tags...") so the phrasing is shorter and keeps the same meaning.
42-42: Consider simplifying "key off of" to "key off".Minor style suggestion: "queries key off" is more concise than "queries key off of".
✏️ Suggested edit
-**`service:` tag** — must match `DD_SERVICE` in the deployment exactly. This is what the Teams filter and `$service` template variable queries key off of. +**`service:` tag** — must match `DD_SERVICE` in the deployment exactly. This is what the Teams filter and `$service` template variable queries key off.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/trogonstack-datadog/skills/datadog-register-dashboard/SKILL.md` at line 42, Update the phrasing in the SKILL.md line that reads "This is what the Teams filter and `$service` template variable queries key off of." to the more concise "queries key off" by replacing "queries key off of" with "queries key off"; locate the sentence that mentions the **`service:` tag** and the `$service` template variable and make this single-wording change to improve style and concision.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/trogonstack-datadog/skills/datadog-register-dashboard/SKILL.md`:
- Around line 118-119: The fenced code block in SKILL.md currently has no
language identifier; update the triple-backtick fence around the dashboard URL
to include a language tag (e.g., change ``` to ```text) so the block becomes a
labeled code block for consistency with Markdown best practices.
---
Nitpick comments:
In `@plugins/trogonstack-datadog/skills/datadog-register-dashboard/SKILL.md`:
- Line 16: The sentence "A well-titled dashboard with no tags is invisible
outside of manually scrolling the list." should be edited for concision; replace
"invisible outside of manually scrolling the list" with "invisible outside
manually scrolling the list" in SKILL.md (edit the sentence that begins "A
well-titled dashboard with no tags...") so the phrasing is shorter and keeps the
same meaning.
- Line 42: Update the phrasing in the SKILL.md line that reads "This is what the
Teams filter and `$service` template variable queries key off of." to the more
concise "queries key off" by replacing "queries key off of" with "queries key
off"; locate the sentence that mentions the **`service:` tag** and the
`$service` template variable and make this single-wording change to improve
style and concision.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 79354792-2783-41fa-8fee-ba0fd084e8fd
📒 Files selected for processing (2)
plugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.mdplugins/trogonstack-datadog/skills/datadog-register-dashboard/SKILL.md
🚧 Files skipped from review as they are similar to previous changes (1)
- plugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.md
plugins/trogonstack-datadog/skills/datadog-register-dashboard/SKILL.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
plugins/trogonstack-datadog/skills/datadog-review-dashboard/SKILL.md (1)
46-47: Use non-interactive list command for consistencyPlease use
pup dashboards list --yeshere as well, so this workflow is consistent with the plugin’s dashboard-listing convention and avoids interactive prompts in scripted runs.Proposed update
-# If given a service name, list all dashboards and identify the relevant one by title -pup dashboards list +# If given a service name, list all dashboards and identify the relevant one by title +pup dashboards list --yes🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/trogonstack-datadog/skills/datadog-review-dashboard/SKILL.md` around lines 46 - 47, Update the non-interactive dashboard listing command in SKILL.md: replace the interactive invocation "pup dashboards list" with the non-interactive form "pup dashboards list --yes" so the workflow follows the plugin’s dashboard-listing convention and avoids interactive prompts; look for the line containing the "pup dashboards list" command in SKILL.md and add the "--yes" flag.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@plugins/trogonstack-datadog/skills/datadog-design-dashboard/references/layouts.md`:
- Line 26: The line asserting "Every widget query must include
`{$service,$env}`" is overly broad; change it to state that including
`{$service,$env}` is required only for service-level dashboards (e.g., RED
Method, Debugging dashboards), and explicitly exempt Infrastructure and
Executive templates — update the documentation under layouts.md to: 1) adjust
the global rule to a conditional rule for service dashboards referencing
`{$service,$env}`, 2) call out the variable sets actually used by the
Infrastructure template (env | host | availability_zone) and Executive template
(env | team | region), and 3) add a short note directing authors of non-service
dashboards to use those template-specific variable scopes instead.
- Around line 11-16: Update the "Required variables" table to stop claiming
`service` is universally required: either add a clear note that `service` is
required only for service-scoped dashboards (RED/Debugging) or split the section
into context-specific tables (e.g., "For Service Dashboards" with `env, service`
and "For Infrastructure/Executive Dashboards" with `env, host,
availability_zone` / `env, team, region`). Also adjust the statement that "every
widget query must include {$service,$env}" to specify it applies only to
service-level dashboards, and make the same corresponding correction in SKILL.md
where the requirement is asserted (the statement around `{$service,$env}`).
---
Nitpick comments:
In `@plugins/trogonstack-datadog/skills/datadog-review-dashboard/SKILL.md`:
- Around line 46-47: Update the non-interactive dashboard listing command in
SKILL.md: replace the interactive invocation "pup dashboards list" with the
non-interactive form "pup dashboards list --yes" so the workflow follows the
plugin’s dashboard-listing convention and avoids interactive prompts; look for
the line containing the "pup dashboards list" command in SKILL.md and add the
"--yes" flag.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8352877c-33d2-4eea-8add-fde9db8c8877
📒 Files selected for processing (5)
plugins/trogonstack-datadog/.claude-plugin/plugin.jsonplugins/trogonstack-datadog/README.mdplugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.mdplugins/trogonstack-datadog/skills/datadog-design-dashboard/references/layouts.mdplugins/trogonstack-datadog/skills/datadog-review-dashboard/SKILL.md
✅ Files skipped from review due to trivial changes (2)
- plugins/trogonstack-datadog/README.md
- plugins/trogonstack-datadog/.claude-plugin/plugin.json
🚧 Files skipped from review as they are similar to previous changes (1)
- plugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.md
plugins/trogonstack-datadog/skills/datadog-design-dashboard/references/layouts.md
Outdated
Show resolved
Hide resolved
plugins/trogonstack-datadog/skills/datadog-design-dashboard/references/layouts.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
plugins/trogonstack-datadog/skills/datadog-design-dashboard/references/layouts.md (1)
11-26:⚠️ Potential issue | 🟠 MajorScope
servicerequirements to service-level dashboards only.This still conflicts with your own Infrastructure/Executive templates that do not define
$service. Please make the requirement conditional by dashboard type instead of universal.Suggested doc fix
-**Required variables** (always include): +**Required variables** (always include for service-level dashboards): ... -- Every widget query must include `{$service,$env}` as the filter scope +- Service-level dashboards: every widget query must include `{$service,$env}`. +- Infrastructure/Executive dashboards: use the template-specific scope (for example `{$host,$env}` or `{$team,$env}`).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/trogonstack-datadog/skills/datadog-design-dashboard/references/layouts.md` around lines 11 - 26, The docs currently mandate that every widget query include {$service,$env}, which conflicts with templates (Infrastructure, Executive) that do not define $service; update the guidance in layouts.md so the `service` requirement is conditional by dashboard type: keep `env` as a universal required variable, and state that `service` is required only for "service-level" dashboards (reference the `service` and `env` variable names and the Infrastructure/Executive templates) and remove the universal sentence "- Every widget query must include {$service,$env}" or replace it with a conditional note explaining when to include `{$service}`.plugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.md (1)
149-150:⚠️ Potential issue | 🟠 MajorQuality checklist should not enforce
$servicefor all dashboard types.For Infrastructure/Executive dashboards, this rule is too strict and inconsistent with your template guidance. Make this conditional by dashboard scope.
Suggested checklist wording
-- [ ] Template variables defined for `env` and `service` (required), plus any relevant scopes (default `*`) -- [ ] Every widget query scoped with `{$service,$env}` — no hardcoded env or service values +- [ ] Service dashboards: define `env` and `service`; non-service dashboards use the template-specific required scopes (all default `*`) +- [ ] Widget queries use template-variable scoping appropriate to dashboard type (e.g., `{$service,$env}` for service dashboards) — no hardcoded scope values🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.md` around lines 149 - 150, The checklist currently mandates template variables "env" and "service" and that "Every widget query scoped with {$service,$env}" for all dashboards; change this to be conditional by dashboard scope: update the checklist text so that Application/Service dashboards require both `env` and `service` template variables and widget queries scoped with `{$service,$env}`, while Infrastructure and Executive dashboards do not require `service` (they may require only `env` or no `service` scoping as appropriate). Locate and edit the lines containing "Template variables defined for `env` and `service` (required)..." and "Every widget query scoped with `{$service,$env}`" to express these conditional requirements and give example wording for each dashboard scope.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@plugins/trogonstack-datadog/skills/datadog-review-dashboard/references/widgets.md`:
- Around line 291-292: Update the "Dashboard title" guideline to follow the new
naming convention by replacing the example "Order Service" with an explicit
bracketed service plus purpose pattern (e.g., "[order-service] Observability")
and keep the rule that titles must not include the "Dashboard" suffix; edit the
"Dashboard title" heading/description in widgets.md (the "Dashboard title:
Concise, purpose-driven." paragraph) to show the new example and a short note
enforcing the no-"Dashboard" suffix rule.
---
Duplicate comments:
In
`@plugins/trogonstack-datadog/skills/datadog-design-dashboard/references/layouts.md`:
- Around line 11-26: The docs currently mandate that every widget query include
{$service,$env}, which conflicts with templates (Infrastructure, Executive) that
do not define $service; update the guidance in layouts.md so the `service`
requirement is conditional by dashboard type: keep `env` as a universal required
variable, and state that `service` is required only for "service-level"
dashboards (reference the `service` and `env` variable names and the
Infrastructure/Executive templates) and remove the universal sentence "- Every
widget query must include {$service,$env}" or replace it with a conditional note
explaining when to include `{$service}`.
In `@plugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.md`:
- Around line 149-150: The checklist currently mandates template variables "env"
and "service" and that "Every widget query scoped with {$service,$env}" for all
dashboards; change this to be conditional by dashboard scope: update the
checklist text so that Application/Service dashboards require both `env` and
`service` template variables and widget queries scoped with `{$service,$env}`,
while Infrastructure and Executive dashboards do not require `service` (they may
require only `env` or no `service` scoping as appropriate). Locate and edit the
lines containing "Template variables defined for `env` and `service`
(required)..." and "Every widget query scoped with `{$service,$env}`" to express
these conditional requirements and give example wording for each dashboard
scope.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d7fb3661-4b70-4a0a-807a-fa9eda5f4baa
📒 Files selected for processing (7)
plugins/trogonstack-datadog/.claude-plugin/plugin.jsonplugins/trogonstack-datadog/README.mdplugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.mdplugins/trogonstack-datadog/skills/datadog-design-dashboard/references/layouts.mdplugins/trogonstack-datadog/skills/datadog-review-dashboard/SKILL.mdplugins/trogonstack-datadog/skills/datadog-review-dashboard/references/thresholds.mdplugins/trogonstack-datadog/skills/datadog-review-dashboard/references/widgets.md
✅ Files skipped from review due to trivial changes (3)
- plugins/trogonstack-datadog/README.md
- plugins/trogonstack-datadog/skills/datadog-review-dashboard/references/thresholds.md
- plugins/trogonstack-datadog/.claude-plugin/plugin.json
🚧 Files skipped from review as they are similar to previous changes (1)
- plugins/trogonstack-datadog/skills/datadog-review-dashboard/SKILL.md
plugins/trogonstack-datadog/skills/datadog-review-dashboard/references/widgets.md
Outdated
Show resolved
Hide resolved
plugins/trogonstack-datadog/skills/datadog-review-dashboard/references/widgets.md
Outdated
Show resolved
Hide resolved
yordis
force-pushed
the
fixes-18
branch
3 times, most recently
from
9b699e4 to
3d138f0
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| # Get the full dashboard definition (includes the dashboard URL in the response) | ||
| pup dashboards get <dashboard-id> | ||
|
|
||
| # Verify real metric names exist |
There was a problem hiding this comment.
Audit fetch step lost --filter flag for dashboard search
Low Severity
The audit "Fetch the dashboard" step uses bare pup dashboards list even when the comment says "If given a service name, list all dashboards and identify the relevant one by title." The deleted datadog-review-dashboard skill used pup dashboards list --filter="<service-name>" for this purpose. Dropping the --filter parameter means the agent will fetch the entire dashboard list instead of narrowing by service name, making it harder to find the relevant dashboard.
…n, and audit workflow Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datadog-name-dashboardskill teaching the[service] Purposenaming pattern, thetitle-field-owns-the-name rule, and thepup dashboards list --yescheck before proposing a namedatadog-design-dashboardquality checklistCloses #18