fix: add Signed-off-by to autobump commit message for DCO compliance#19
fix: add Signed-off-by to autobump commit message for DCO compliance#19
Conversation
…them chore commits are hidden from release-please, meaning merged bump PRs would never trigger a new tap release. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Bot-created bump PRs were failing DCO because the commit lacked a Signed-off-by trailer. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview Written by Cursor Bugbot for commit bb726f0. This will update automatically on new commits. Configure here. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe autobump workflow commit message is updated to include a Signed-off-by metadata line. The change adds a blank line separator after the version bump line and appends a Signed-off-by attribution, modifying the commit message format without altering other workflow logic. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| with: | ||
| token: ${{ secrets.GH_PAT_RELEASE_PLEASE_ACTION }} | ||
| commit-message: "feat: bump ${{ matrix.formula }} to ${{ steps.upstream.outputs.version }}" | ||
| commit-message: "feat: bump ${{ matrix.formula }} to ${{ steps.upstream.outputs.version }}\n\nSigned-off-by: TrogonStack Bot <bot@trogonstack.com>" |
There was a problem hiding this comment.
Signed-off-by email won't match default commit author
Medium Severity
The Signed-off-by trailer specifies TrogonStack Bot <bot@trogonstack.com>, but no author or committer inputs are set on the create-pull-request step. The action defaults to github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> as the commit author. The widely-used probot DCO checker requires the Signed-off-by email to match the commit author email — so DCO checks will likely still fail despite this change.


Bot-created bump PRs fail DCO because the commit lacks a
Signed-off-bytrailer. Adds it to thecommit-messagein thecreate-pull-requeststep.