refactor(protoc-gen-pony): remove mapValuePonyType duplicate of elemPonyType#49
Conversation
PR SummaryLow Risk Overview Also drops a redundant doc comment above Reviewed by Cursor Bugbot for commit 49dd0ab. Bugbot is set up for automated code reviews on this repo. Configure here. |
…onyType mapValuePonyType was identical to elemPonyType in every branch. Replace all 4 call sites and delete the function. Also drop the redundant isWKT doc comment — wktBlocklist's comment above it already captures the full reasoning. Signed-off-by: Erik Nilsen <enilsen16@live.com>
275de14 to
e62e2f8
Compare
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 55 minutes and 56 seconds.Comment |
Summary
mapValuePonyTypewas identical toelemPonyTypein every branch (MessageKind, EnumKind, scalar default). Removed the duplicate and replaced all 4 call sites withelemPonyType.isWKT— thewktBlocklistvar comment directly above it already explains the reasoning in full.Test plan
go test ./cmd/protoc-gen-pony/— all 36 tests pass (no behavior change)