refactor(telemetry): generalize service instrumentation#152
Merged
Conversation
Member
yordis
commented
May 6, 2026
yordis
commented
- Telemetry ownership needs to match the Trogon services that share it, not only ACP binaries.
- Resource attribution needs to support protocol-specific identity without coupling observability to ACP naming.
- Shared telemetry lifecycle behavior reduces drift across binaries that initialize and shut down OpenTelemetry.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (26)
WalkthroughThis PR renames the ChangesTelemetry Crate Rename and API Refactoring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR SummaryMedium Risk Overview
Operational config changes: file logging env var is renamed from Reviewed by Cursor Bugbot for commit 7411092. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Code Coverage SummaryDetailsDiff against mainResults for commit: 7411092 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 898e42f. Configure here.
yordis
added
the
rust:coverage-baseline-reset
yordis
force-pushed
the
yordis/refactor-telemetry
branch
2 times, most recently
from
f216241 to
1f0e72d
Compare
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/refactor-telemetry
branch
from
1f0e72d to
7411092
Compare
mariorha
added a commit
that referenced
this pull request
May 12, 2026
Resolves all conflicts from 5 commits: - refactor(gateway): consolidate source adapters (#153) - feat(mcp-nats): support distributed MCP (#149) - refactor(telemetry): generalize service instrumentation (#152) - fix(signal): share shutdown boundary (#151) - fix(acp-nats): preserve typed NATS subject contracts (#150) Key decisions: - trogon-source-* Cargo.toml files deleted (accepted gateway consolidation) - acp-nats-server: accepted origin/main (registry routing removed by fix #150) - trogon-telemetry: generic resource_attributes API accepted (fix #152) - service_name.rs: combined AcpNatsWs + McpNatsStdio/McpNatsServer variants - Platform crates migrated from acp-telemetry to trogon-telemetry - signal::shutdown_signal moved from acp-telemetry to trogon-std - Orphaned trogon-source-* dirs excluded from workspace (tests preserved)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.