refactor(acp-nats): typed subjects enforce correct transport at compile time#76
Merged
refactor(acp-nats): typed subjects enforce correct transport at compile time#76
Conversation
PR SummaryMedium Risk Overview Updates agent/client proxy code (including the Hardens prompt-response waiter handling by propagating mutex-poisoning as a Written by Cursor Bugbot for commit b493fb1. This will update automatically on new commits. Configure here. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (70)
WalkthroughThis PR refactors NATS subject construction from string-based helpers to typed Subject structs implementing marker traits. It introduces a new structured subject module hierarchy, adds Changes
Sequence Diagram(s)The changes primarily involve refactoring existing APIs and data flow patterns without introducing new multi-component interaction sequences. Subject construction, handler invocation, and NATS messaging patterns remain functionally equivalent, so a sequence diagram would not provide additional clarity beyond the existing code logic. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code Coverage SummaryDetailsDiff against mainResults for commit: b493fb1 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
yordis
force-pushed
the
refactor/typed-subjects-poc
branch
2 times, most recently
from
4f5a90e to
c0eeef1
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
yordis
force-pushed
the
refactor/typed-subjects-poc
branch
4 times, most recently
from
4bc1d90 to
12a58bb
Compare
yordis
force-pushed
the
refactor/typed-subjects-poc
branch
2 times, most recently
from
f446336 to
dfdba45
Compare
yordis
force-pushed
the
refactor/typed-subjects-poc
branch
4 times, most recently
from
c98326c to
156ea8b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
yordis
force-pushed
the
refactor/typed-subjects-poc
branch
3 times, most recently
from
9b35a1e to
2225087
Compare
Each NATS subject is its own struct with typed parameters (AcpPrefix, AcpSessionId). Marker traits (Requestable, Publishable, SessionCommand, Subscribable, ClientRequestable) enforce correct transport at compile time — passing a CancelSubject to request_with_timeout is a compile error, not a runtime bug. Also removes all production .unwrap() calls: - publish_session_ready: gracefully handles invalid session IDs - PendingSessionPromptResponseWaiters: returns Result for poison errors Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
refactor/typed-subjects-poc
branch
from
2225087 to
b493fb1
Compare
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestSubject,PublishSubject, andJetStreamSubjectnewtypes that encode the transport at the type levelinitialize()returnsRequestSubject,prompt()returnsJetStreamSubject,cancel()returnsPublishSubjectnats::request_with_timeout,nats::publish,bridge.session_request) only accept the correct type — misuse is a compile error