Skip to content

Strategy changes + ephemeral nodes#71

Merged
ZachCutler04 merged 6 commits into
alphafrom
zc/strategyChanges
May 12, 2025
Merged

Strategy changes + ephemeral nodes#71
ZachCutler04 merged 6 commits into
alphafrom
zc/strategyChanges

Conversation

@ZachCutler04
Copy link
Copy Markdown
Contributor

3 main contributions from this PR

  1. Updated our save strategy to now automatically create a checkpoint every 25 nodes (number changeable when initializing trrack) and otherwise always save patch nodes.
  2. Made it possible to directly force a single node to be a checkpoint
  3. Added back idea of ephemeral nodes, and made undo/redo chain skip over ephemeral nodes. More work should be done in trrack vis to account for ephemeral nodes as well.

@ZachCutler04 ZachCutler04 requested a review from kirangadhave May 12, 2025 21:09
@vercel
Copy link
Copy Markdown

vercel Bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trrackjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 10:26pm

Copy link
Copy Markdown
Member

@kirangadhave kirangadhave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for the most part. Requested some minor changes

Comment thread packages/core/src/graph/components/node.ts Outdated
Comment thread packages/core/src/graph/components/node.ts Outdated
Comment thread packages/core/src/provenance/trrack.ts Outdated
Comment thread packages/core/src/provenance/trrack.ts Outdated
Copy link
Copy Markdown
Member

@kirangadhave kirangadhave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 looks good to me

@ZachCutler04 ZachCutler04 changed the base branch from main to alpha May 12, 2025 22:33
@ZachCutler04 ZachCutler04 merged commit b24cb3f into alpha May 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants