Fixed bug in Apcu driver with abstract getStats() method#635
Merged
Geolim4 merged 1 commit intoTruCopilot:masterfrom Jul 23, 2018
Merged
Fixed bug in Apcu driver with abstract getStats() method#635Geolim4 merged 1 commit intoTruCopilot:masterfrom
Geolim4 merged 1 commit intoTruCopilot:masterfrom
Conversation
The Apcu driver passes `$stats['mem_size']` to the function `setSize()` of `DriverStatistic`. This generates an error due to type mismatch. The function `setSize()` expects and integer while `$stats['mem_size']` is a float.
Member
|
Hello, Please keep the PR template next time, thanks :) You are using Apcu on php7 right ? I'm asking you that because I was unable to test it after php 5.6. Cheers, |
Geolim4
approved these changes
Jul 23, 2018
Member
|
Bump @afdaniele :) |
Contributor
Author
|
@Geolim4 , I'm sorry for the template, I'll use it next time. Yes, I'm using Apcu on PHP7 and so far so good, I didn't have to use any trick to make it work and didn't have any issue either. I'll let you know if I have any issue in the future. Cheers, |
Member
|
Okay I didn't known that they have ported Apcu extension to php7. Thanks for your contribution, |
Geolim4
changed the title
Contributor
Author
|
Sure! Cheers, |
Member
|
FYI 7.0.2 has been released :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The Apcu driver passes
$stats['mem_size']to the functionsetSize()ofDriverStatistic. This generates an error due to type mismatch. The functionsetSize()expects and integer while$stats['mem_size']is a float.Types of changes
What types of changes does your code introduce to Phpfastcache?
Put an
xin the boxes that applyAgreement
I have read the CONTRIBUTING and CODING GUIDELINE docs
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...