Skip to content

[master] Fix composer package name should be all lowercase#669

Merged
Geolim4 merged 1 commit intoTruCopilot:masterfrom
jfcherng:fix-composer-readme
Jan 31, 2019
Merged

[master] Fix composer package name should be all lowercase#669
Geolim4 merged 1 commit intoTruCopilot:masterfrom
jfcherng:fix-composer-readme

Conversation

@jfcherng
Copy link
Copy Markdown
Contributor

@jfcherng jfcherng commented Jan 29, 2019

Proposed changes

Composer 1.8.2 (latest) would now emit a deprecation warning that package name should in lowercase.

So I think it would be better to change the install command in the README.

Deprecation warning: require.phpFastCache/phpfastcache is invalid, it should not contain uppercase characters. 
Please use phpfastcache/phpfastcache instead. Make sure you fix this as Composer 2.0 will error.

Types of changes

What types of changes does your code introduce to Phpfastcache?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing code/behavior)
  • Deprecated third party dependency update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation/Typo/Resource update that does not involve any code modification

Agreement

I have read the CONTRIBUTING and CODING GUIDELINE docs

Deprecation warning: require.phpFastCache/phpfastcache is invalid,
it should not contain uppercase characters. Please use
phpfastcache/phpfastcache instead. Make sure you fix this
as Composer 2.0 will error.

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@Geolim4
Copy link
Copy Markdown
Member

Geolim4 commented Jan 31, 2019

Thanks for your contribution :)

@Geolim4 Geolim4 merged commit f50545a into TruCopilot:master Jan 31, 2019
@Geolim4
Copy link
Copy Markdown
Member

Geolim4 commented Jan 31, 2019

Also you can make me a PR on v5/v6 if you want :)

@jfcherng jfcherng changed the title Fix composer package name should be all lowercase [master] Fix composer package name should be all lowercase Jan 31, 2019
@jfcherng jfcherng deleted the fix-composer-readme branch January 31, 2019 09:37
@jfcherng
Copy link
Copy Markdown
Contributor Author

@Geolim4 Sure. My pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants