[master] Fix composer package name should be all lowercase#669
Merged
Geolim4 merged 1 commit intoTruCopilot:masterfrom Jan 31, 2019
jfcherng:fix-composer-readme
Merged
[master] Fix composer package name should be all lowercase#669Geolim4 merged 1 commit intoTruCopilot:masterfrom jfcherng:fix-composer-readme
Geolim4 merged 1 commit intoTruCopilot:masterfrom
jfcherng:fix-composer-readme
Conversation
Deprecation warning: require.phpFastCache/phpfastcache is invalid, it should not contain uppercase characters. Please use phpfastcache/phpfastcache instead. Make sure you fix this as Composer 2.0 will error. Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Geolim4
approved these changes
Jan 31, 2019
Member
|
Thanks for your contribution :) |
Member
|
Also you can make me a PR on v5/v6 if you want :) |
Contributor
Author
|
@Geolim4 Sure. My pleasure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Composer 1.8.2 (latest) would now emit a deprecation warning that package name should in lowercase.
So I think it would be better to change the install command in the README.
Types of changes
What types of changes does your code introduce to Phpfastcache?
Put an
xin the boxes that applyAgreement
I have read the CONTRIBUTING and CODING GUIDELINE docs