fixes #700 for v6: Psr16Adapter::deleteMultiple converts $keys to an array#704
Merged
Geolim4 merged 2 commits intoSep 4, 2019
Merged
Conversation
…eys to an array. The internal Psr\Cache\CacheItemPoolInterface::deleteItems requires an array as argument. Some popular tools like PhpSpreadsheet use a Traversable instead. This is the fix for the v6 branch.
bylexus
changed the title
Member
|
Why did you re-opened the same PR ? |
Member
|
Ahhh my bad.... V6 Sorry ! |
… Traversable $keys in an array The internal array_map function can only be used with native arrays.
Geolim4
approved these changes
Sep 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal Psr\Cache\CacheItemPoolInterface::deleteItems requires an array as argument. Some popular tools like PhpSpreadsheet use a Traversable instead.
This is the fix for the v6 branch.
Proposed changes
deleteMultiple() should convert the
$keysargument to an array, as the underlyingCacheItemPoolInterface::deleteItems()method takes arrays only.Types of changes
Agreement
I have read the CONTRIBUTING and CODING GUIDELINE docs
Further comments
This issue also appears in the master branch: I have committed another pull request for the master branch.