Redis config cannot accept null values as the given example#774
Merged
Geolim4 merged 3 commits intoTruCopilot:masterfrom Nov 27, 2020
GeoSot:fix-redis-config
Merged
Redis config cannot accept null values as the given example#774Geolim4 merged 3 commits intoTruCopilot:masterfrom GeoSot:fix-redis-config
Geolim4 merged 3 commits intoTruCopilot:masterfrom
GeoSot:fix-redis-config
Conversation
Geolim4
requested changes
Nov 26, 2020
Member
Geolim4
left a comment
There was a problem hiding this comment.
Hello,
Don't forget to also change the properties declarations and theirs annotation.
Thanks :)
Geolim4
approved these changes
Nov 27, 2020
Contributor
Author
|
@Geolim4 can you update the version, on packagist? |
Member
|
Hello, Sadly I already updated the version last week (8.0.3) so you have to be patient until next month or use Cheers, |
Member
|
8.0.4 release is out 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
According to this example, password and database options can be nullable.
For a given server setup I need these values to be null but, the Config setters didn't accept null values and thrown exception.
Types of changes
What types of changes does your code introduce to Phpfastcache?
Put an
xin the boxes that applyAgreement
I have read the CONTRIBUTING and CODING GUIDELINE docs