Skip to content

Ensured full PHP8 compatibility#777

Merged
Geolim4 merged 4 commits intoTruCopilot:masterfrom
Geolim4:master
Dec 19, 2020
Merged

Ensured full PHP8 compatibility#777
Geolim4 merged 4 commits intoTruCopilot:masterfrom
Geolim4:master

Conversation

@Geolim4
Copy link
Copy Markdown
Member

@Geolim4 Geolim4 commented Dec 19, 2020

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Phpfastcache?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing code/behavior)
  • Deprecated third party dependency update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation/Typo/Resource update that does not involve any code modification

Agreement

I have read the CONTRIBUTING and CODING GUIDELINE docs

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

pfc-bot
pfc-bot previously approved these changes Dec 19, 2020
Copy link
Copy Markdown
Collaborator

@pfc-bot pfc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good :)

Copy link
Copy Markdown
Collaborator

@pfc-bot pfc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good :)

@Geolim4 Geolim4 enabled auto-merge (squash) December 19, 2020 23:53
@Geolim4 Geolim4 disabled auto-merge December 19, 2020 23:53
@Geolim4 Geolim4 enabled auto-merge December 19, 2020 23:54
@Geolim4 Geolim4 merged commit 800ae53 into TruCopilot:master Dec 19, 2020
@Geolim4 Geolim4 linked an issue Dec 20, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP8 compatibility

3 participants