Skip to content

Allow $cacheItem to be retrieved by callback argument in CacheConditionalHelper#800

Merged
Geolim4 merged 2 commits intoTruCopilot:masterfrom
Geolim4:master
Jun 30, 2021
Merged

Allow $cacheItem to be retrieved by callback argument in CacheConditionalHelper#800
Geolim4 merged 2 commits intoTruCopilot:masterfrom
Geolim4:master

Conversation

@Geolim4
Copy link
Copy Markdown
Member

@Geolim4 Geolim4 commented Jun 29, 2021

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Phpfastcache?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing code/behavior)
  • Deprecated third party dependency update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation/Typo/Resource update that does not involve any code modification

Agreement

I have read the CONTRIBUTING and CODING GUIDELINE docs

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

pfc-bot
pfc-bot previously approved these changes Jun 29, 2021
Copy link
Copy Markdown
Collaborator

@pfc-bot pfc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good :)

pfc-bot
pfc-bot previously approved these changes Jun 30, 2021
Copy link
Copy Markdown
Collaborator

@pfc-bot pfc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good :)

Copy link
Copy Markdown
Collaborator

@pfc-bot pfc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good :)

@Geolim4 Geolim4 merged commit 86210a1 into TruCopilot:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants