Skip to content

Update comment#891

Merged
Geolim4 merged 1 commit intoTruCopilot:masterfrom
janschoenherr:patch-1
Feb 2, 2023
Merged

Update comment#891
Geolim4 merged 1 commit intoTruCopilot:masterfrom
janschoenherr:patch-1

Conversation

@janschoenherr
Copy link
Copy Markdown
Contributor

The comment did not match the time calculation.

Proposed changes

Just a typo.

Types of changes

What types of changes does your code introduce to Phpfastcache?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing code/behavior)
  • Deprecated third party dependency update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation/Typo/Resource update that does not involve any code modification

Agreement

I have read the CONTRIBUTING and CODING GUIDELINE docs

The comment did not match the time calculation.
@Geolim4
Copy link
Copy Markdown
Member

Geolim4 commented Feb 2, 2023

Nice catch, thanks !

@janschoenherr janschoenherr temporarily deployed to github-ci February 2, 2023 14:18 — with GitHub Actions Inactive
@Geolim4 Geolim4 enabled auto-merge February 2, 2023 14:18
@Geolim4 Geolim4 self-assigned this Feb 2, 2023
@Geolim4 Geolim4 added the $_$ WIKI/DOC Wiki / Documentation related issue label Feb 2, 2023
@Geolim4 Geolim4 disabled auto-merge February 2, 2023 14:48
@Geolim4
Copy link
Copy Markdown
Member

Geolim4 commented Feb 2, 2023

Seems like travis pipeline is buggy again today, safe to merge with only Github CI.

@Geolim4 Geolim4 merged commit 50ea4d6 into TruCopilot:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

$_$ WIKI/DOC Wiki / Documentation related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants