Fix: also delete the cached file on disk#85
Merged
Conversation
TrueBrain
force-pushed
the
more_cache_fixes
branch
2 times, most recently
from
f157b94 to
f73d4cf
Compare
If a logged-in user generated a file, LAST_TIME_RENDERED was set, but the cache on disk is not written. Now if there was an older version of the cache still on disk, on next request from a visitor that is not logged-in, the old cache would be served. Validate that the time set in LAST_TIME_RENDERED is in fact also the time of the cache-file on disk. If not, the file on disk is stale and a new page should be rendered.
TrueBrain
force-pushed
the
more_cache_fixes
branch
from
f73d4cf to
7c2c425
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a logged-in user generated a file, LAST_TIME_RENDERED was set,
but the cache on disk is not written. Now if there was an older
version of the cache still on disk, on next request from a visitor
that is not logged-in, the old cache would be served. Solve this
by also removing the cache from the disk, so it cannot do this,
and a new page will be rendered and served.