Skip to content

Conversation

@marcin-trust
Copy link
Contributor

Align with current LTS support

12, 14, 16 are LTS versions
https://nodejs.org/en/about/releases/

Align with current LTS support

12, 14, 16 are LTS versions
https://nodejs.org/en/about/releases/
@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2022

🦋 Changeset detected

Latest commit: ef5feea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@usedapp/coingecko Minor
@usedapp/core Minor
@usedapp/extension Minor
@usedapp/testing Minor
@usedapp/example Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jodator
Copy link
Contributor

jodator commented Jan 7, 2022

@marcin-trust It looks like the test 16 was canceled. I'm re-running the jobs to see if this was a GH hickup.

@marcin-trust
Copy link
Contributor Author

@jodator at the same time you need to reconfigure branch policy and remove 10.x and 12.x required checks

@jodator
Copy link
Contributor

jodator commented Jan 7, 2022

@jodator at the same time you need to reconfigure branch policy and remove 10.x and 12.x required checks

Yep, we will need to do this after the merge. For now, it looks like the job on node 16 is running for too long. Could check why is that?

@marcin-trust
Copy link
Contributor Author

node v16 test run hangs locally. why-is-node-running prints forever in async hook loop or sth.
I added --exit to mocha and I'll create an issue

@marcin-trust
Copy link
Contributor Author

#476 related

@marcin-trust
Copy link
Contributor Author

I added --exit to mocha and I'll create an issue

It didn't help

@jodator
Copy link
Contributor

jodator commented Jan 10, 2022

It didn't help

@marcin-trust Could you check to add --exit flag to other packages? I've tested this locally, and I had to add this flag to all packages.

@marcin-trust
Copy link
Contributor Author

@jodator - yes, it helped, let's see in this PR

@marcin-trust
Copy link
Contributor Author

I forgot about testing project. Now it should work in CI too

@marcin-trust
Copy link
Contributor Author

It got passed. Now you @jodator need to update the required check rules.

@jodator
Copy link
Contributor

jodator commented Jan 11, 2022

@marcin-trust I think that the last step is also to include a change set as we introduce a breaking change. Since we're still on 0.x I'd go with MINOR. Other than that, we're good to go.

@jodator jodator merged commit ece010c into TrueFiEng:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants