[EWT-567] Version info management simplification#293
Merged
Conversation
|
✅ Linked to Bug EWT-567 · Java lib - compatibility issue with Kotlin |
dili91
force-pushed
the
version-info-loader-simplification
branch
from
c136af0 to
fe8c5f5
Compare
dili91
commented
Jun 13, 2024
| task createProperties(dependsOn: processResources) { | ||
| doLast { | ||
| new File("$buildDir/resources/main/truelayer-java.version.properties").withWriter { w -> | ||
| file("${layout.buildDirectory.get()}/resources/main/truelayer-java.version.properties").withWriter { w -> |
Contributor
Author
There was a problem hiding this comment.
this helps us getting rid of a deprecation warning
dili91
commented
Jun 13, 2024
| .getClassLoader() | ||
| .getResource(CONFIG_FILE_PREXIF + "." + "version" + ".properties")) | ||
| .getPath()))); | ||
| versionInfoProps.load(getClass() |
Contributor
Author
There was a problem hiding this comment.
This method directly returns an InputStream, which is suitable for reading resources from the classpath, including resources inside JAR files. This approach abstracts away the underlying file system details and works uniformly across different environments.
tl-luca-baggi
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently had an incompatibility issue with Kotlin projects because of the way we load the file used to propagate library-version related informations to Java code. It turns out that the relying on
getResourceAsStreamabstracts away the underlying file system details and works uniformly across different environments.