Skip to content

[EWT-590] Fix mandates acceptance tests#296

Merged
tl-luca-baggi merged 1 commit intomainfrom
EWT-590
Jun 24, 2024
Merged

[EWT-590] Fix mandates acceptance tests#296
tl-luca-baggi merged 1 commit intomainfrom
EWT-590

Conversation

@tl-luca-baggi
Copy link
Contributor

Description

In mandates acceptance tests, we have some testing scenario requiring us to wait and poll a mandate until it reaches a certain status, before proceeding with assertions and/or other operations.

The method taking care of this polling operation was using by mistake the tlClient built in the base class, which uses default scopes: as a result, we were invoking the GET /mandates endpoint always using the recurring_payments:sweeping scope (the default if not set explicitly when building the client), and this was causing calls related to cVRP mandates to fail (a recurring_payments:commercial scope is expected in this case).

This PR will fix the bug, that went unnoticed for some time until a stricter check on scopes had been introduced by PGW (PR here for reference)

Type of change

Please select multiple options if required.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the relevant documentation

@tl-luca-baggi tl-luca-baggi requested a review from a team as a code owner June 24, 2024 13:55
@tl-luca-baggi tl-luca-baggi requested a review from a team June 24, 2024 13:55
@swarmia
Copy link

swarmia bot commented Jun 24, 2024

✅  Linked to Task EWT-590 · Fix Java library acceptance tests

@tl-luca-baggi tl-luca-baggi merged commit 0c9c9e6 into main Jun 24, 2024
@tl-luca-baggi tl-luca-baggi deleted the EWT-590 branch June 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants