[EWT-590] Fix mandates acceptance tests#296
Merged
tl-luca-baggi merged 1 commit intomainfrom Jun 24, 2024
Merged
Conversation
|
✅ Linked to Task EWT-590 · Fix Java library acceptance tests |
tl-facundo-aita
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In mandates acceptance tests, we have some testing scenario requiring us to wait and poll a mandate until it reaches a certain status, before proceeding with assertions and/or other operations.
The method taking care of this polling operation was using by mistake the
tlClientbuilt in the base class, which uses default scopes: as a result, we were invoking the GET /mandates endpoint always using therecurring_payments:sweepingscope (the default if not set explicitly when building the client), and this was causing calls related to cVRP mandates to fail (arecurring_payments:commercialscope is expected in this case).This PR will fix the bug, that went unnoticed for some time until a stricter check on scopes had been introduced by PGW (PR here for reference)
Type of change
Please select multiple options if required.
Checklist: