Skip to content

[ACL-175] Fix missing EqualsAndHashCode Lombok annotations#304

Merged
dili91 merged 6 commits intomainfrom
ACL-175
Aug 5, 2024
Merged

[ACL-175] Fix missing EqualsAndHashCode Lombok annotations#304
dili91 merged 6 commits intomainfrom
ACL-175

Conversation

@tl-luca-baggi
Copy link
Contributor

Description

  • Add missing EqualsAndHashCode lombok annotations on PaymentMethod subclasses and related properties
  • Add unit tests

Type of change

Please select multiple options if required.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the relevant documentation

@tl-luca-baggi tl-luca-baggi requested review from a team as code owners August 1, 2024 14:46
@tl-luca-baggi tl-luca-baggi marked this pull request as draft August 1, 2024 15:08
private final Type type = Type.INSTANT_PREFERRED;

@Accessors(fluent = true)
@JsonProperty // Jackson's @JsonProperty is required for serialization to work as expected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something to bear in mind when we use fluent accessors in request DTOs

@dili91 dili91 marked this pull request as ready for review August 5, 2024 09:50
@dili91 dili91 merged commit 600f252 into main Aug 5, 2024
@dili91 dili91 deleted the ACL-175 branch August 5, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants