Skip to content

[ACL-180] Add preselected scheme selection to preselected provider#312

Merged
tl-luca-baggi merged 3 commits intomainfrom
ACL-180
Sep 17, 2024
Merged

[ACL-180] Add preselected scheme selection to preselected provider#312
tl-luca-baggi merged 3 commits intomainfrom
ACL-180

Conversation

@tl-luca-baggi
Copy link
Contributor

@tl-luca-baggi tl-luca-baggi commented Sep 16, 2024

Description

Add scheme_selection property to preselected provider selection.

NB the object is slightly different from the one referenced in user_selected provider selection, as it has an extra type preselected. As such, I had to refactor a bit the code and it resulted in a breaking change

I didn't find a convenient way to avoid duplicating code for common scheme selection types like InstantOnly and InstantPreferred, because of the constraints introduced by the way we serialize / deserialize objects with multiple subtypes

Type of change

Please select multiple options if required.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the relevant documentation

@tl-luca-baggi tl-luca-baggi requested review from a team as code owners September 16, 2024 08:26
group=com.truelayer
archivesBaseName=truelayer-java
version=13.3.0
version=14.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved some classes around (e.g. created packages userselected and preselected inside schemeselection package)

import com.truelayer.java.entities.ProviderFilter;
import com.truelayer.java.payments.entities.SchemeId;
import com.truelayer.java.payments.entities.schemeselection.SchemeSelection;
import com.truelayer.java.payments.entities.schemeselection.userselected.SchemeSelection;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tl-luca-baggi tl-luca-baggi merged commit a51d5b8 into main Sep 17, 2024
@tl-luca-baggi tl-luca-baggi deleted the ACL-180 branch September 17, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants