Skip to content

[ACL-159] Add user_selected scheme selection#313

Merged
tl-luca-baggi merged 1 commit intomainfrom
ACL-159
Sep 18, 2024
Merged

[ACL-159] Add user_selected scheme selection#313
tl-luca-baggi merged 1 commit intomainfrom
ACL-159

Conversation

@tl-luca-baggi
Copy link
Contributor

Description

Add user_selected scheme selection type

Type of change

Please select multiple options if required.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the relevant documentation

@tl-luca-baggi tl-luca-baggi requested review from a team as code owners September 17, 2024 15:56

public class SchemeSelectionTests {

@DisplayName("Scheme selection base class should yield the expected type and allow_remitter_fee")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this as the base class does not have the allowRemitterFee property anymore

@tl-luca-baggi tl-luca-baggi merged commit 42ffeab into main Sep 18, 2024
@tl-luca-baggi tl-luca-baggi deleted the ACL-159 branch September 18, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants