Merged
Conversation
|
|
||
| private final Clock clock; | ||
|
|
||
| public SimpleAccessTokenCache(Clock clock) { |
Contributor
Author
There was a problem hiding this comment.
the Clock param makes testing easier.
Please note that this is not a monotonic implementation. But in the end I think it's fine
| AccessToken accessToken = new AccessToken( | ||
| UUID.randomUUID().toString(), | ||
| RandomUtils.nextInt(), | ||
| 3600, |
Contributor
Author
There was a problem hiding this comment.
This is to mimic reality more and ease the testing phase
|
|
||
| @BeforeAll | ||
| public static void setup(WireMockRuntimeInfo wireMockRuntimeInfo) { | ||
| @BeforeEach |
Contributor
Author
There was a problem hiding this comment.
Even if not a problem in past, this should have been done probably already as this guarantees tha each integration test is stateless. It now becomes a requirement, so that we can test cache properly
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "access_token": "eyJ***immediate", | |||
| "expires_in": 1, | |||
Contributor
Author
There was a problem hiding this comment.
this is to ease integration tests
Contributor
|
LGTM |
tl-luca-baggi
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by this article.
I'm combining both an interceptor and an authenticator to handle token caching and refreshes on 401 events.