[JSDK-57] Optional credentials caching + custom pluggable cache#94
Merged
tl-andrea-dilisio merged 5 commits intomainfrom Mar 18, 2022
Merged
[JSDK-57] Optional credentials caching + custom pluggable cache#94tl-andrea-dilisio merged 5 commits intomainfrom
tl-andrea-dilisio merged 5 commits intomainfrom
Conversation
|
Thanks Andrea, looks good to me |
tl-luca-baggi
approved these changes
Mar 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One of the feedback from the Security team during their pre go-live review was to make the credentials caching optional. This PR onboards that change and pushes a bit further by making the cache implementation customizable.
To enable the default cache (in memory ) users will have to build a client like this
Whereas, if a custom cache is needed, developers can provide an implementation of the
ICredentialsCacheinterfaceMore on this Wiki page
Type of change
Please select multiple options if required.
Checklist: