Conversation
The plugin-runtime.mjs entry point and embedded-runtime feature were removed as part of the Rust-owned runtime core rewrite, but the release-cli.yml workflow still tried to build and package the deleted file. This caused prepare-cli-runtime to fail with: ls: cannot access 'cli/dist/plugin-runtime.mjs': No such file Changes: - Remove the prepare-cli-runtime job entirely - Remove plugin-runtime artifact download/copy from build-binary - Remove obsolete --features tnmsc/embedded-runtime from cargo commands - Renumber remaining workflow steps Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the obsolete
prepare-cli-runtimejob and allplugin-runtime.mjsreferences from the release workflow.Background
The
plugin-runtime.mjsentry point and theembedded-runtimefeature were removed as part of the Rust-owned runtime core rewrite (sdk/build.rsexplicitly documents this). However,release-cli.ymlstill attempted to build, upload, and package the deleted file, causing the release workflow to fail with:Changes
prepare-cli-runtimejob entirely.cli-plugin-runtimeartifact download and copy steps frombuild-binary.--features tnmsc/embedded-runtimeflag fromcargo buildandcargo testcommands.Verification
release-cli.ymlnow contains no references toplugin-runtimeorembedded-runtime.build-binaryjob only depends onpreflightandpublish-napi.