Skip to content

feat: docked queue only, lyrics panel fix, Genius CI secret#77

Merged
JoePittsy merged 2 commits into
mainfrom
develop
May 7, 2026
Merged

feat: docked queue only, lyrics panel fix, Genius CI secret#77
JoePittsy merged 2 commits into
mainfrom
develop

Conversation

@JoePittsy
Copy link
Copy Markdown
Member

We Shall Fight in the Queue

We shall go on to the end. We shall fight in the home panel, we shall fight on the lyrics view and the album pages, we shall fight with growing confidence and growing strength in the sidebar — we shall defend our queue, whatever the cost may be.

We shall fight in the floating overlay — and we have abolished it, for it served us no longer. We shall fight on the docked panel, we shall fight in the resize handle, we shall fight on the right-hand column of the viewport; we shall never surrender the queue to ambiguity of mode.

What We Have Done

We have eliminated floating mode. The queue is docked. It has always been docked. It shall always be docked. The toggle is gone. The conditional rendering is gone. 257 lines have been deleted and 39 put in their place. This is not a defeat — this is a liberation.

We have fixed the lyrics panel. It had been skulking beneath the queue sidebar, an affront to the eye and to the layout engine. The background now sweeps magnificently across the full viewport — even behind the queue — while the content itself knows its place and stops at the queue's left edge. Order has been restored.

We have brought the Genius token to the front. It had been left behind in the pipeline, forgotten — a secret that was secret even from the build that needed it. GENIUS_ACCESS_TOKEN now marches alongside its brethren in the publish workflow. The descriptions shall flow.

We have fixed the supermix icon path, for even in victory one must tend to the small things.

Test Plan

  • Queue sidebar is always docked — no mode toggle anywhere in settings
  • Lyrics panel background fills full viewport width (including behind queue)
  • Lyrics content does not overlap the queue sidebar
  • Genius descriptions load on the lyrics panel in a production build
  • All 708 tests pass (npm run test:run)
  • Typecheck clean (npm run typecheck)

🤖 Generated with Claude Code

Joe Pitts and others added 2 commits May 7, 2026 10:49
- Remove floating queue mode entirely; docked sidebar is the sole UI
- Lyrics panel background now spans full viewport (including behind queue)
  while content area stops at the queue edge via margin-right CSS var
- Fix GENIUS_ACCESS_TOKEN missing from publish workflow env
- Fix icon path in HomePanel supermix fallback

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 81.16% 1668 / 2055
🔵 Statements 78.14% 1931 / 2471
🔵 Functions 73.84% 545 / 738
🔵 Branches 71.89% 1768 / 2459
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
renderer/src/App.tsx 70.37% 55.73% 46.15% 74.4% 61, 62, 68, 81-82, 92, 111-112, 118, 123, 131, 139, 142, 147, 154-158, 205, 226-242, 260-262, 267, 351-363, 388-390, 398, 437-443, 508-516
renderer/src/components/HomePanel.tsx 81.25% 62.26% 87.5% 78.57% 103-115
renderer/src/components/PlayerBar.tsx 83.11% 67.64% 80.76% 86.15% 44, 74, 75, 93-98, 125, 199, 300
renderer/src/components/TopNav.tsx 77.21% 70.66% 65.51% 79.71% 72, 82-87, 133-136, 201, 211-216, 244, 245-276
renderer/src/components/album/AlbumPanel.tsx 77.89% 85.59% 73.68% 82.35% 46, 82-97, 108, 140, 197
renderer/src/components/queue/QueueSidebar.tsx 50.97% 59.63% 61.7% 53.79% 87-95, 100, 110, 115, 122, 129, 135, 141, 150-173, 205-263, 280, 321-326, 362
renderer/src/types/globals.d.ts 100% 100% 100% 100%
Generated in workflow #120 for commit a98cd70 by the Vitest Coverage Report Action

@JoePittsy JoePittsy merged commit df736dc into main May 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant