chore(jvchat): upgrade to React 19#75
Merged
Merged
Conversation
Bump react / react-dom / @types/react / @types/react-dom to ^19 and regenerate
package-lock.json. Fixes the one React 19 breaking change in the tree: the
global `JSX` namespace was removed, so JsonViewer.tsx's `JSX.Element` return
types now import the type explicitly (`import type { JSX } from "react"`).
The @assistant-ui/*, radix-ui, @testing-library/react, lucide, etc. ecosystem
all dedupe cleanly onto react@19. jvchat build (tsc && vite build), lint
(eslint --max-warnings 0), and tests (vitest, 55 passing) are green under 19.
Supersedes dependabot #65 (partial bump — it missed @types/react-dom, causing the
install-time ERESOLVE). Closes #73.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ck-yaml - Regenerate package-lock.json cleanly (rm + npm install) so it's fully in sync — the incremental install left it missing a transitive dep, so `npm ci` (what CI runs) failed with EUSAGE. `npm ci` now installs clean. - Exclude auto-generated pnpm-lock.yaml from check-yaml (mirrors #74): main's pnpm-lock carries a duplicate key from the #69 merge that trips the strict parser; lockfiles shouldn't be yaml-linted. jvchat uses npm ci, not pnpm. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the React 19 upgrade that dependabot #65 couldn't (it bumped
react/react-dom/@types/reactbut missed@types/react-dom, so install died withERESOLVE). Closes #73.Changes
react/react-dom/@types/react/@types/react-dom→^19;package-lock.jsonregenerated.JSXnamespace was removed, soJsonViewer.tsx'sJSX.Elementreturn types nowimport type { JSX } from "react".Verified locally (full jvchat CI, React 19)
npm install— clean;@assistant-ui/*,radix-ui,@testing-library/react,lucide, etc. all dedupe ontoreact@19.2.7.npm run build(tsc && vite build) — ✓ (3197 modules).npm run lint(eslint --max-warnings 0) — ✓.npm test(vitest) — ✓ 55 passing.Note
pre-commitcheck-yamlmay show red onpnpm-lock.yamluntil #74 lands — that's a pre-existingmaincorruption (duplicate@codemirror/state@6.7.0from the #69 lockfile merge). #74 excludes auto-generated lockfiles fromcheck-yaml; rebasing this on main after #74 merges clears it. (jvchat usespackage-lock.json/npm ci;pnpm-lock.yamlis vestigial.)🤖 Generated with Claude Code