fix: resolve serialize-javascript to 7.0.5 in lockfile (Dependabot #90)#116
Merged
chrismaz11 merged 1 commit intomasterfrom Apr 11, 2026
Merged
fix: resolve serialize-javascript to 7.0.5 in lockfile (Dependabot #90)#116chrismaz11 merged 1 commit intomasterfrom
chrismaz11 merged 1 commit intomasterfrom
Conversation
…#90 Changes nested mocha override to a top-level override so the lockfile resolves serialize-javascript to 7.0.5 instead of remaining at 7.0.3. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates dependency resolution to clear Dependabot alert #90 by ensuring serialize-javascript is resolved to a secure version in the lockfile.
Changes:
- Switches npm override from a nested
mocha.serialize-javascriptoverride to a top-levelserialize-javascriptoverride. - Updates
package-lock.jsonsoserialize-javascriptresolves to7.0.5(and aligns the recorded Node engine constraint).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Replaces the prior nested override with a top-level serialize-javascript override. |
| package-lock.json | Updates the resolved serialize-javascript tarball/integrity to 7.0.5 (and updates the recorded Node engine field). |
| "mocha": { | ||
| "serialize-javascript": "7.0.5" | ||
| } | ||
| "serialize-javascript": ">=7.0.5" |
There was a problem hiding this comment.
The override uses an unbounded range (">=7.0.5"), which can allow npm to resolve a future breaking major (e.g., 8.x) during a lockfile refresh. To keep installs predictable while still addressing the advisory, prefer pinning to "7.0.5" or using a bounded range like "^7.0.5" (or ">=7.0.5 <8").
Suggested change
| "serialize-javascript": ">=7.0.5" | |
| "serialize-javascript": "7.0.5" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the initial override bump: the nested
mocha.serialize-javascriptoverride did not update the resolved version in the lockfile. This PR:mocha.serialize-javascriptto a top-levelserialize-javascript >= 7.0.5npm update serialize-javascript --package-lock-onlyto resolve7.0.5in the lockfileTest plan
🤖 Generated with Claude Code