-
Notifications
You must be signed in to change notification settings - Fork 2
Feature/78 4th and 5th endpoint work #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ion-oset @stratofax I know you guys are busy, but I would like to have plenty of time to address any comments to this PR before the code freeze. And this PR has been open for a while. Said another way, if there are no comments today, let me know if it is NOT ok to merge this as is with a comment here. I would to merge it by tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼. Mostly minor comments.
Co-authored-by: Ion Y <78449689+ion-oset@users.noreply.github.com>
Co-authored-by: Ion Y <78449689+ion-oset@users.noreply.github.com>
Co-authored-by: Ion Y <78449689+ion-oset@users.noreply.github.com>
|
All your fixes LGTM. |
…tr]] and not native csv
At a high level this PR contains the following work:
Creating this PR early so there is time to potentially address issues in case it wants to be included in the release branch.