Skip to content

Conversation

@thokkat
Copy link
Collaborator

@thokkat thokkat commented Jul 26, 2024

Fixes a c&p leftover where parameter run was checked twice in AnimationSolver::solveAnim. Introduced here 825bf12.

@Try
Copy link
Owner

Try commented Jul 27, 2024

Hi, @thokkat and thanks for PR!

Can you please, provide a test case, for me to do the testing?

@thokkat
Copy link
Collaborator Author

thokkat commented Jul 27, 2024

Charging Spells:

ItSc_Pyrokinesis
ItSc_ChargeFireball
ItSc_Windfist
ItSc_Thunderball

After change all are fixed.

@thokkat thokkat marked this pull request as draft July 28, 2024 16:54
@thokkat
Copy link
Collaborator Author

thokkat commented Jul 28, 2024

In Gothic 1 shoot animation is used as invest animation for spells like teleport. Stumbled upon pr issue while testing G1 spells so wanna look into the new issue first.

@thokkat
Copy link
Collaborator Author

thokkat commented Jul 30, 2024

Ok in G1s non-charging spells like firestorm are called with invest=true which gives the CAST instead of the SHOOT animation. Fallback S_SHOOT kicks in an gives the right animation. Should this be changed to find the transition animation or is state animation sufficient?

@Try
Copy link
Owner

Try commented Jul 30, 2024

Should this be changed to find the transition animation or is state animation sufficient?

OpenGothic animation system usually prefer state-animations (maybe not best design). PR looks good, testing is fine, are you OK with merging it?

@thokkat thokkat marked this pull request as ready for review July 30, 2024 22:46
@Try Try merged commit 0c5366e into Try:master Jul 31, 2024
@Try
Copy link
Owner

Try commented Jul 31, 2024

Merged, thanks!

@Abendlied Abendlied mentioned this pull request Aug 1, 2024
14 tasks
@thokkat thokkat deleted the spell-animation branch August 25, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants