Skip to content

Conversation

@TonyTroeff
Copy link
Member

@TonyTroeff TonyTroeff commented Aug 24, 2023

Pull Request Description

Implemented a method that should return the position of the least significant unset bit for a given Bitmask.

Motivation and Context

We have a similar method called FindLeastSignificantSetBit that allows us to find the position of the least significant set bit. However, the opposite is not achievable from outside of the Bitmask implementation. That's why we decided to expose a new method that will guarantee optimal performance.

Checklist

  • I have tested these changes thoroughly.
  • I have added/updated relevant documentation.
  • My code follows the project's coding guidelines.
  • I have performed a self-review of my changes.
  • My changes are backwards compatible.

@TonyTroeff TonyTroeff added documentation Improvements or additions to documentation feature Something that should be implemented labels Aug 24, 2023
@TonyTroeff TonyTroeff self-assigned this Aug 24, 2023
Copy link
Member Author

@TonyTroeff TonyTroeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no comments after self-reviewing my PR.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@TonyTroeff TonyTroeff merged commit b578752 into main Aug 24, 2023
@TonyTroeff TonyTroeff deleted the troeff/least-significant-unset-bit branch August 24, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation feature Something that should be implemented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a method that should return the position of the least significant unset bit

2 participants