Conversation
ref https://linear.app/ghost/issue/AP-1008 - Staging resource names changed. CD has to reflect those name changes.
WalkthroughThis pull request updates the GitHub Actions workflow in the Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build.yml (1)
132-137: Matrix Include Update: Descriptive Region NamingThe updated matrix include block now provides a descriptive
region_namefor each region (e.g.,netherlandsforeurope-west4andfrankfurtforeurope-west3). This change improves clarity in subsequent deployment steps while continuing to usematrix.regionwhere the actual deployment region is required.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build.yml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build, Test and Push
🔇 Additional comments (3)
.github/workflows/build.yml (3)
150-151: Migration Job Name UpdatedThe migration job name now uses
matrix.region_name—i.e.,stg-${{ matrix.region_name }}-activitypub-migrations—which aligns with the new naming convention. This makes resource identification much clearer.
157-159: Service Name Update for ActivityPub QueueThe service name for the ActivityPub Queue has been updated to use
matrix.region_name(stg-${{ matrix.region_name }}-activitypub-queue), improving naming clarity. It’s important that the deployment maintains the correct region configuration by still usingmatrix.regionwhere needed.
164-166: Service Name Update for ActivityPub APISimilarly, the ActivityPub API service now references
matrix.region_name(stg-${{ matrix.region_name }}-activitypub-api), which enhances readability and consistency in the deployment resource names.
ref https://linear.app/ghost/issue/AP-1008