Fixed cicd tear down condition to destroy a staging environment

[rmgpinto]

ref https://linear.app/ghost/issue/AP-976

• Added closed to the pr check to tear down the staging environment.

[coderabbitai]

Walkthrough

The workflow file responsible for tearing down ephemeral staging environments was updated to broaden the criteria for environment deletion. Previously, the workflow only targeted pull requests that had been merged. With this change, the workflow will now also target pull requests that have been closed, regardless of whether they were merged. This adjustment ensures that environments associated with both merged and closed pull requests are marked for deletion. No other aspects of the workflow logic were modified.

Possibly related PRs

• Added ephemeral staging environments #432: Introduced ephemeral staging environments and their deployment logic, which is complemented by the expanded teardown conditions in this PR.
• Added ephemeral staging environments tear down job #536: Added automated teardown for merged PRs, which is directly built upon by now including closed PRs in the teardown process.

Suggested labels

ricardo.ghost.is

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

.github/workflows/ephemeral-staging-teardown.yml (1)

39-39: Confirm GH CLI state values and simplify condition

The gh pr view --json state field maps merged PRs to CLOSED (GraphQL only has OPEN or CLOSED), so the "MERGED" branch will never fire. You can simplify this to:

if [ "$PR_STATE" = "CLOSED" ]; then
  …
fi

If you truly need to distinguish merged vs. unmerged closures, fetch the boolean with:

gh pr view $PR_NUMBER --json state,merged | jq -r '.merged'

and test .merged.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4e52812 and f38c336.

📒 Files selected for processing (1)

• .github/workflows/ephemeral-staging-teardown.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build, Test and Push