Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

[SPIKE] New mobiledoc based editor#6

Closed
kevinansfield wants to merge 18 commits intoTryGhost:masterfrom
kevinansfield:new-editor
Closed

[SPIKE] New mobiledoc based editor#6
kevinansfield wants to merge 18 commits intoTryGhost:masterfrom
kevinansfield:new-editor

Conversation

@kevinansfield
Copy link
Copy Markdown
Member

requires TryGhost/Ghost#6255

Spike/prototype to test out new editor functionality based around https://github.com/bustlelabs/mobiledoc-kit

TODO:

NB. This has expanded into a dumping ground for ideas and things that will need looking at moving forward, I expect a number of these will be pulled out into separate issues.

  • Isolate existing editor
  • Add "New Editor" labs flag
  • Swap new editor in/out based on labs flag
  • Integrate mobiledoc editor component
    • Initial ember-mobiledoc-editor integration
    • Basic toolbar styles
    • Basic editor content area styles
  • Add mobiledoc field to posts table
  • Generate HTML from mobiledoc when post is saved on the server
  • Display appropriate editor and notification if opening a markdown/mobiledoc post that doesn't correspond with the current labs flag setting
  • SimpleMDE markdown card (in progress)
    • Display simplemde interface when card is in edit mode
    • Display rendered html when card is in display mode
    • Lazy-load card assets
    • Render simplemde markdown card during server rendering
  • Improved UI for inserting cards
  • Look into possibility of having discrete rich-text content blocks (at least from a UI perspective) instead of the whole document area acting as a rich-text editor
    • Remove always-present rich-text toolbar and only show it when editing a rich-text area
  • CodeMirror card
  • Ghost markdown card (adapt existing editor to work as a mobiledoc card)
  • Method for cards to register themselves
    • Enumerate and instantiate ember component cards on client
    • Enumerate and instantiate server-side cards for rendering
    • Display dynamically loaded cards in the "insert card" UI
    • Investigate options for packaging cards as discrete units

ISSUES:

  • Mobiledoc's Position class seems to have trouble when the content area is scrollable
  • Cards have a space above & below that appear to be editable text but it's not possible to type unless pressing 'enter' to create a new paragraph
  • Pressing bold/italic toolbar buttons does not immediately change mode - it's necessary to select some text and then press the button.
  • When the cursor is at the end of a bold/italic section the corresponding toolbar button is not highlighted even though typing will continue to be bold/italic

Investigate:

  • Options for converting existing markdown/html to mobiledoc
  • Options for image cards

@kevinansfield kevinansfield changed the title [Spike] New mobiledoc based editor [SPIKE] New mobiledoc based editor May 22, 2016
@kevinansfield
Copy link
Copy Markdown
Member Author

Closing as this has served it's purpose and we're now working on a new mobiledoc implementation.

@kevinansfield kevinansfield deleted the new-editor branch February 4, 2017 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant