Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

adjust mobile styles for apps-module (#8744)#813

Merged
kevinansfield merged 1 commit into
TryGhost:masterfrom
farhd:apps-mobile-styles
Aug 17, 2017
Merged

adjust mobile styles for apps-module (#8744)#813
kevinansfield merged 1 commit into
TryGhost:masterfrom
farhd:apps-mobile-styles

Conversation

@farhd
Copy link
Copy Markdown
Contributor

@farhd farhd commented Aug 1, 2017

responsive styles for .apps-configured and .apps-card adjusted, so that elements fit smaller device screens.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 73.041% when pulling 4c315f2 on farhd:apps-mobile-styles into fb316a9 on TryGhost:master.

@aileen
Copy link
Copy Markdown
Member

aileen commented Aug 2, 2017

Hey @farhd! Thanks for the PR! Usually, we use media queries in Ghost to take care of anything that is not desktop width. The way you implemented it, is the other way around. If you could change it, so it fits better in the Ghost coding style, that would be great!

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.3%) to 73.295% when pulling 28fad72 on farhd:apps-mobile-styles into fb316a9 on TryGhost:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.3%) to 73.295% when pulling fd47db9 on farhd:apps-mobile-styles into fb316a9 on TryGhost:master.

@farhd farhd force-pushed the apps-mobile-styles branch from fd47db9 to ac73d0c Compare August 2, 2017 11:47
@farhd
Copy link
Copy Markdown
Contributor Author

farhd commented Aug 2, 2017

Hi @AileenCGN. thank you for your feedback. I adjusted as you asked.
Question: Do you plan to refactor CSS media-queries to use some custom-properties, because at the moment a developer has to find out what MQ is implicitly 'defined'. i.e. I had to look for other MQs and try to get a feeling for the right one. it would be nicer though to have 3-5 defined values for different screen-width ranges.

@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling ac73d0c on farhd:apps-mobile-styles into ** on TryGhost:master**.

@kevinansfield kevinansfield merged commit fb63f8d into TryGhost:master Aug 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants