You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 28, 2022. It is now read-only.
Hey @farhd! Thanks for the PR! Usually, we use media queries in Ghost to take care of anything that is not desktop width. The way you implemented it, is the other way around. If you could change it, so it fits better in the Ghost coding style, that would be great!
Hi @AileenCGN. thank you for your feedback. I adjusted as you asked.
Question: Do you plan to refactor CSS media-queries to use some custom-properties, because at the moment a developer has to find out what MQ is implicitly 'defined'. i.e. I had to look for other MQs and try to get a feeling for the right one. it would be nicer though to have 3-5 defined values for different screen-width ranges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
responsive styles for .apps-configured and .apps-card adjusted, so that elements fit smaller device screens.