Remove some !important declarations #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Updated to fix tag pages and so on. |
Member
|
Does this fix the issue where the icon appears white by default? |
Relates to b071548 - Fixes an issue where the menu button would be the wrong colour The navigation was using `!important` in a few places. I've changed the CSS a bit to no longer need these, but that means I've made some selectors slightly more specific. The use of `!important` was to get around the hover state being persisted when the menu was opened but the mouse hadn't moved, which meant the menu button kept its white background when it should be black. iMaking the hover state only apply when the nav is closed, gets around that.
Member
Author
|
Yep :) I've updated the commit & PR message to clarify that.
|
JohnONolan
added a commit
that referenced
this pull request
Apr 11, 2015
Remove some !important declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to b071548
The navigation was using
!importantin a few places. I've changed the CSS a bit to no longer need these, but that means I've made some selectors slightly more specific.The use of
!importantwas to get around the hover state being persisted when the menu was opened but the mouse hadn't moved, which meant the menu button kept its white background when it should be black.Making the hover state only apply when the nav is closed, gets around that.
I also added comments to a few other
!important's