Skip to content

Make <kbd> tag look more like a button#822

Closed
artemkovalyov wants to merge 1 commit intoTryGhost:mainfrom
artemkovalyov:patch-1
Closed

Make <kbd> tag look more like a button#822
artemkovalyov wants to merge 1 commit intoTryGhost:mainfrom
artemkovalyov:patch-1

Conversation

@artemkovalyov
Copy link
Copy Markdown

@artemkovalyov artemkovalyov commented Oct 17, 2021 •
edited
Loading

The kbd tag is often used in tech articles and it doesn't look nice at the moment. By the way, it's also looking wrong in the editor.
That's how it should look after this change.

image

@artemkovalyov
Make <kbd> tag look more like a button
cdb1701 
The <kbd> tag is often used in tech articles and it doesn't look nice at the moment. By the way, it's also looking wrong in the editor.
@minimaluminium
Copy link
Copy Markdown
Member

minimaluminium commented Jan 3, 2022

Hey @artemkovalyov, thanks for your PR! I've just closed this one, and added <kbd> support in 1f34187. This is how it looks in light and dark mode.

CleanShot 2022-01-03 at 12 07 15@2x

CleanShot 2022-01-03 at 12 07 27@2x

@artemkovalyov
Copy link
Copy Markdown
Author

artemkovalyov commented Jan 4, 2022

Amazing, @minimaluminium, thanks for investing into making it look like it should:)

QzSG added a commit to QzSG/Casper that referenced this pull request May 4, 2022
@QzSG
Squashed commit of the following:
c825e18 
commit 7c88702
Merge: 96699d9 ff4e422
Author: QzSG <quantumparadoxes@gmail.com>
Date:   Wed May 4 15:03:01 2022 +0800

    Merge remote-tracking branch 'upstream/main' into temp

commit ff4e422
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon May 2 17:44:06 2022 +0800

    v4.7.5

commit 9a09ff4
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon May 2 17:43:02 2022 +0800

    Add a class name to site description

commit f41761e
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Apr 8 18:05:35 2022 +0800

    v4.7.4

commit 11b52ed
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Apr 8 18:04:54 2022 +0800

    Fix paginated posts of the list layout

commit c3fa4f6
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Mar 28 15:48:20 2022 +0800

    Remove deprecated ghost-api property

commit 19d5b6c
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Mar 23 11:15:07 2022 +0800

    Remove unused csscomb files

commit 76f0037
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Mar 1 11:44:07 2022 +0800

    v4.7.3

commit 37a0918
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Mar 1 11:43:00 2022 +0800

    Make editor and markdown blockquote styles consistent

commit 13458e0
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Jan 26 13:10:55 2022 +0800

    Add a class to card meta author

commit eb007cb
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Jan 25 14:28:22 2022 +0800

    Show read more wrapper when only there are other recent posts

commit 55f5ba6
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Fri Jan 14 10:39:46 2022 +0000

    Update dependency gscan to v4.22.0 (TryGhost#827)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 5cdcda1
Author: John O'Nolan <john@onolan.org>
Date:   Wed Jan 5 12:43:26 2022 +0000

    2022

commit 18f6d85
Author: Maegan Wilson <maegan@maeganwilson.com>
Date:   Mon Jan 3 15:39:38 2022 -0600

    Updating spelling fixes TryGhost#834

commit 1f34187
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Jan 3 12:08:16 2022 +0800

    Add <kbd> style

    fixes TryGhost#822

commit 05d0b0c
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 17 18:16:43 2021 +0800

    v4.7.2

commit 08f480f
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 17 18:16:21 2021 +0800

    Update dark style header card background color

commit 56ec2e9
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 17 16:30:15 2021 +0800

    v4.7.1

commit c4f2d74
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 17 16:24:24 2021 +0800

    Apply custom heading color only to light header style

commit c378e9a
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 17 15:58:13 2021 +0800

    v4.7.0

commit db98015
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 17 15:06:34 2021 +0800

    Header card tweaks

commit 7e9cf5c
Author: Daniel Lockyer <hi@daniellockyer.com>
Date:   Thu Dec 16 09:46:13 2021 +0100

    v4.6.1

commit 0f9a3c7
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Thu Dec 16 12:53:45 2021 +0800

    Fix list layout style on medium screen size

commit 8ff91f7
Author: Peter Zimon <zimo@ghost.org>
Date:   Wed Dec 15 15:00:52 2021 +0100

    Updated callout emoji line-height

commit feb2de7
Author: Sam Lord <hello@samlord.me>
Date:   Wed Dec 15 13:02:03 2021 +0000

    v4.6.0

commit 9b45ff3
Author: Peter Zimon <zimo@ghost.org>
Date:   Wed Dec 15 13:06:42 2021 +0100

    Card css specificity update (TryGhost#832)

    The default CSS styles of new Koenig cards that have been released in the past couple of weeks was updated for better usability in themes in general (read commit message for reasons and more reference).

    This commit contains CSS cleanup and updates in theme styles that aligns Casper to this change.

commit 827f372
Author: Peter Zimon <zimo@ghost.org>
Date:   Tue Dec 14 14:38:49 2021 +0100

    Updated styles for file upload card

commit ffdf853
Author: Daniel Lockyer <hi@daniellockyer.com>
Date:   Mon Dec 13 17:47:11 2021 +0100

    v4.5.0

commit e454355
Author: Thibaut Patel <thibaut@ghost.org>
Date:   Mon Dec 13 17:23:49 2021 +0100

    Fixed a rule so that it doesn't overrides the product card css

    refs https://github.com/TryGhost/Team/issues/1245

    - Followed the same pattern as the callout, ntf and bookmark cards.

commit 67e7291
Author: Rafael Corrêa Gomes <rafaelstz@users.noreply.github.com>
Date:   Thu Oct 14 23:17:40 2021 -0400

    Footer > Adding Lazy loading in the profile image

commit c880856
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 10 09:55:52 2021 +0800

    Revert dark mode style of product card rating

commit b06bcd6
Author: Daniel Lockyer <hi@daniellockyer.com>
Date:   Wed Dec 8 15:00:14 2021 +0000

    v4.4.0

commit 49f99d9
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Dec 8 17:17:47 2021 +0800

    Add dark mode support to product card star rating

commit cdb03b6
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Dec 7 19:05:00 2021 +0800

    Add alternate blockquote styles

commit e80f22c
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Dec 6 18:52:26 2021 +0800

    v4.3.1

commit b647444
Author: Peter Zimon <zimo@ghost.org>
Date:   Sat Dec 4 08:14:00 2021 -0400

    Updated toggle styles

commit 4627709
Author: Peter Zimon <zimo@ghost.org>
Date:   Sat Dec 4 08:06:09 2021 -0400

    Updated callout styles

commit 017a282
Author: Daniel Lockyer <hi@daniellockyer.com>
Date:   Wed Dec 1 12:56:41 2021 +0000

    v4.3.0

commit 198f12b
Author: Daniel Lockyer <hi@daniellockyer.com>
Date:   Wed Dec 1 12:55:55 2021 +0000

    Updated `yarn.lock`

    no issue

    - this needed updating after we bumped gscan

commit 4826013
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Nov 29 13:33:59 2021 +0800

    Update toggle card heading selector

commit 8b392ec
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Thu Nov 25 18:42:19 2021 +0800

    Add typography option to toggle card heading

commit 4ea9843
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Thu Nov 25 10:44:09 2021 +0800

    Card responsive style refinements

commit 6bc9b02
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Thu Nov 25 10:31:36 2021 +0800

    Add toggle content flow spacing

commit c1006ec
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Nov 24 10:50:46 2021 +0800

    Use data attribute for Portal links

commit cad48b2
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Nov 23 11:32:24 2021 +0800

    Add missing styles for toggle card content

commit b3f6b8a
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Nov 23 11:28:35 2021 +0800

    Include lists inside toggle card to content styling

commit 2d940d8
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Nov 23 11:22:56 2021 +0800

    Exclude default CTA links from link styling

commit b7ea0cb
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Nov 22 21:37:28 2021 +0800

    Upgrade gscan

commit a8150f7
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Nov 22 21:35:48 2021 +0800

    Include toggle text in content styling

commit b5b1ea0
Author: Peter Zimon <zimo@ghost.org>
Date:   Fri Nov 19 12:02:09 2021 +0100

    Updated NFT card styles

commit 370b9ec
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Nov 19 16:07:09 2021 +0800

    Include .kg-callout-text to content styling

commit 3cbe9b2
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Nov 17 18:22:47 2021 +0800

    Remove bookmark card related CSS

commit d652252
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Nov 17 17:02:16 2021 +0800

    Remove gallery card related CSS and JS

commit 6107a41
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Nov 17 14:15:29 2021 +0800

    Exclude cards from default link styling

    refs https://github.com/TryGhost/Team/issues/1227

commit 8feb988
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Nov 15 13:22:03 2021 +0800

    Update heading selector on dark mode

commit e898d56
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Nov 5 20:58:43 2021 +0800

    v4.2.0

commit b8319c5
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Nov 5 20:17:41 2021 +0800

    Update gscan

commit ceaa887
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Nov 5 20:14:53 2021 +0800

    Add custom settings
jonock pushed a commit to jonock/Casper_rideable that referenced this pull request May 28, 2022
@minimaluminium @jonock
Add <kbd> style
947a85b 
fixes TryGhost#822
QzSG added a commit to QzSG/Casper that referenced this pull request Mar 28, 2023
@QzSG
Squashed commit of the following:
4b4ea37 
commit ff4e422
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon May 2 17:44:06 2022 +0800

    v4.7.5

commit 9a09ff4
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon May 2 17:43:02 2022 +0800

    Add a class name to site description

commit f41761e
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Apr 8 18:05:35 2022 +0800

    v4.7.4

commit 11b52ed
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Apr 8 18:04:54 2022 +0800

    Fix paginated posts of the list layout

commit c3fa4f6
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Mar 28 15:48:20 2022 +0800

    Remove deprecated ghost-api property

commit 19d5b6c
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Mar 23 11:15:07 2022 +0800

    Remove unused csscomb files

commit 76f0037
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Mar 1 11:44:07 2022 +0800

    v4.7.3

commit 37a0918
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Mar 1 11:43:00 2022 +0800

    Make editor and markdown blockquote styles consistent

commit 13458e0
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Jan 26 13:10:55 2022 +0800

    Add a class to card meta author

commit eb007cb
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Jan 25 14:28:22 2022 +0800

    Show read more wrapper when only there are other recent posts

commit 55f5ba6
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Fri Jan 14 10:39:46 2022 +0000

    Update dependency gscan to v4.22.0 (TryGhost#827)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 5cdcda1
Author: John O'Nolan <john@onolan.org>
Date:   Wed Jan 5 12:43:26 2022 +0000

    2022

commit 18f6d85
Author: Maegan Wilson <maegan@maeganwilson.com>
Date:   Mon Jan 3 15:39:38 2022 -0600

    Updating spelling fixes TryGhost#834

commit 1f34187
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Jan 3 12:08:16 2022 +0800

    Add <kbd> style

    fixes TryGhost#822

commit 05d0b0c
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 17 18:16:43 2021 +0800

    v4.7.2

commit 08f480f
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 17 18:16:21 2021 +0800

    Update dark style header card background color

commit 56ec2e9
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 17 16:30:15 2021 +0800

    v4.7.1

commit c4f2d74
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 17 16:24:24 2021 +0800

    Apply custom heading color only to light header style

commit c378e9a
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 17 15:58:13 2021 +0800

    v4.7.0

commit db98015
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 17 15:06:34 2021 +0800

    Header card tweaks

commit 7e9cf5c
Author: Daniel Lockyer <hi@daniellockyer.com>
Date:   Thu Dec 16 09:46:13 2021 +0100

    v4.6.1

commit 0f9a3c7
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Thu Dec 16 12:53:45 2021 +0800

    Fix list layout style on medium screen size

commit 8ff91f7
Author: Peter Zimon <zimo@ghost.org>
Date:   Wed Dec 15 15:00:52 2021 +0100

    Updated callout emoji line-height

commit feb2de7
Author: Sam Lord <hello@samlord.me>
Date:   Wed Dec 15 13:02:03 2021 +0000

    v4.6.0

commit 9b45ff3
Author: Peter Zimon <zimo@ghost.org>
Date:   Wed Dec 15 13:06:42 2021 +0100

    Card css specificity update (TryGhost#832)

    The default CSS styles of new Koenig cards that have been released in the past couple of weeks was updated for better usability in themes in general (read commit message for reasons and more reference).

    This commit contains CSS cleanup and updates in theme styles that aligns Casper to this change.

commit 827f372
Author: Peter Zimon <zimo@ghost.org>
Date:   Tue Dec 14 14:38:49 2021 +0100

    Updated styles for file upload card

commit ffdf853
Author: Daniel Lockyer <hi@daniellockyer.com>
Date:   Mon Dec 13 17:47:11 2021 +0100

    v4.5.0

commit e454355
Author: Thibaut Patel <thibaut@ghost.org>
Date:   Mon Dec 13 17:23:49 2021 +0100

    Fixed a rule so that it doesn't overrides the product card css

    refs https://github.com/TryGhost/Team/issues/1245

    - Followed the same pattern as the callout, ntf and bookmark cards.

commit 67e7291
Author: Rafael Corrêa Gomes <rafaelstz@users.noreply.github.com>
Date:   Thu Oct 14 23:17:40 2021 -0400

    Footer > Adding Lazy loading in the profile image

commit c880856
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Dec 10 09:55:52 2021 +0800

    Revert dark mode style of product card rating

commit b06bcd6
Author: Daniel Lockyer <hi@daniellockyer.com>
Date:   Wed Dec 8 15:00:14 2021 +0000

    v4.4.0

commit 49f99d9
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Dec 8 17:17:47 2021 +0800

    Add dark mode support to product card star rating

commit cdb03b6
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Dec 7 19:05:00 2021 +0800

    Add alternate blockquote styles

commit e80f22c
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Dec 6 18:52:26 2021 +0800

    v4.3.1

commit b647444
Author: Peter Zimon <zimo@ghost.org>
Date:   Sat Dec 4 08:14:00 2021 -0400

    Updated toggle styles

commit 4627709
Author: Peter Zimon <zimo@ghost.org>
Date:   Sat Dec 4 08:06:09 2021 -0400

    Updated callout styles

commit 017a282
Author: Daniel Lockyer <hi@daniellockyer.com>
Date:   Wed Dec 1 12:56:41 2021 +0000

    v4.3.0

commit 198f12b
Author: Daniel Lockyer <hi@daniellockyer.com>
Date:   Wed Dec 1 12:55:55 2021 +0000

    Updated `yarn.lock`

    no issue

    - this needed updating after we bumped gscan

commit 4826013
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Nov 29 13:33:59 2021 +0800

    Update toggle card heading selector

commit 8b392ec
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Thu Nov 25 18:42:19 2021 +0800

    Add typography option to toggle card heading

commit 4ea9843
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Thu Nov 25 10:44:09 2021 +0800

    Card responsive style refinements

commit 6bc9b02
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Thu Nov 25 10:31:36 2021 +0800

    Add toggle content flow spacing

commit c1006ec
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Nov 24 10:50:46 2021 +0800

    Use data attribute for Portal links

commit cad48b2
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Nov 23 11:32:24 2021 +0800

    Add missing styles for toggle card content

commit b3f6b8a
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Nov 23 11:28:35 2021 +0800

    Include lists inside toggle card to content styling

commit 2d940d8
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Tue Nov 23 11:22:56 2021 +0800

    Exclude default CTA links from link styling

commit b7ea0cb
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Nov 22 21:37:28 2021 +0800

    Upgrade gscan

commit a8150f7
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Nov 22 21:35:48 2021 +0800

    Include toggle text in content styling

commit b5b1ea0
Author: Peter Zimon <zimo@ghost.org>
Date:   Fri Nov 19 12:02:09 2021 +0100

    Updated NFT card styles

commit 370b9ec
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Nov 19 16:07:09 2021 +0800

    Include .kg-callout-text to content styling

commit 3cbe9b2
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Nov 17 18:22:47 2021 +0800

    Remove bookmark card related CSS

commit d652252
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Nov 17 17:02:16 2021 +0800

    Remove gallery card related CSS and JS

commit 6107a41
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Wed Nov 17 14:15:29 2021 +0800

    Exclude cards from default link styling

    refs https://github.com/TryGhost/Team/issues/1227

commit 8feb988
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Mon Nov 15 13:22:03 2021 +0800

    Update heading selector on dark mode

commit e898d56
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Nov 5 20:58:43 2021 +0800

    v4.2.0

commit b8319c5
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Nov 5 20:17:41 2021 +0800

    Update gscan

commit ceaa887
Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Date:   Fri Nov 5 20:14:53 2021 +0800

    Add custom settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artemkovalyov @minimaluminium