Skip to content

Commit ffab312

Browse files
committed
UI/CSS Improvements
Remove shadow on last tag item hover, was an inconsistent style addition thats not used elsewhere such as the content list - Remove box-shadow on last of type settings tag hover state - http://g.recordit.co/CEglFT7Hlr.gif Remove * selector and specify user-select on individual classes for performance. - remove * selector - update classes that benefit from user-select none Having different visuals based around if a radio/checkbox uses a label or not is weird and style changes should use a class modifier. - Merged the two together as I was unable to find an example checkbox/radio in use that did not use the label tag Improved UI for radio/checkboxes - Added cursor pointer to radio/checkboxes - Added hover state to radio/checkboxes Add cursor to select boxes for usability - cursor: pointer; added to select boxes Add hover state to post edit icon - add dark grey hover state to post edit icon Add visual hover to nav user menu dropdown - Move dropdown icon to visually indicate hover
1 parent 6095300 commit ffab312

File tree

4 files changed

+20
-18
lines changed

4 files changed

+20
-18
lines changed

core/client/app/styles/layouts/content.css

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,9 @@
227227
border: none;
228228
font-size: 18px;
229229
}
230+
.content-preview .post-controls .post-edit:hover {
231+
color: var(--darkgrey);
232+
}
230233

231234
.content-preview img {
232235
width: 100%;

core/client/app/styles/layouts/main.css

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ body > .ember-view:not(.liquid-target-container) {
6363
display: flex;
6464
align-items: center;
6565
padding: 15px;
66+
cursor: pointer;
6667
}
6768

6869
.gh-nav-menu i {
@@ -71,10 +72,11 @@ body > .ember-view:not(.liquid-target-container) {
7172
height: 11px;
7273
font-size: 11px;
7374
line-height: 11px;
75+
transition: margin-top 0.2s ease;
7476
}
7577

76-
.gh-nav-menu:hover {
77-
cursor: pointer;
78+
.gh-nav-menu:hover i {
79+
margin-top: 5px;
7880
}
7981

8082
.gh-nav-menu-icon {

core/client/app/styles/layouts/tags.css

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@
2323
border-left: 3px solid;
2424
}
2525

26-
.settings-tag:last-of-type:hover .tag-edit-button {
27-
box-shadow: inset 0 -1px 0 #dfe1e3;
28-
}
29-
3026
.settings-tag .label {
3127
display: inline-block;
3228
overflow: hidden;

core/client/app/styles/patterns/forms.css

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
/* Forms
22
/* ---------------------------------------------------------- */
33

4-
form * {
5-
user-select: text;
6-
}
7-
84
form label {
95
display: block;
106
color: var(--darkgrey);
117
font-size: 1.3rem;
128
font-weight: bold;
9+
user-select: text;
1310
}
1411

1512
form .word-count {
@@ -21,6 +18,7 @@ fieldset {
2118
margin: 0 0 3em 0;
2219
padding: 0;
2320
border: none;
21+
user-select: text;
2422
}
2523

2624
legend {
@@ -31,6 +29,7 @@ legend {
3129
color: #b1b1b1;
3230
font-size: 1.2em;
3331
line-height: 2.0em;
32+
user-select: text;
3433
}
3534

3635
input {
@@ -50,6 +49,7 @@ input {
5049
margin-bottom: 1.6em;
5150
max-width: 500px;
5251
width: 100%;
52+
user-select: text;
5353
}
5454

5555
.form-group p {
@@ -122,6 +122,7 @@ select {
122122
font-size: 1.4rem;
123123
font-weight: normal;
124124
user-select: text;
125+
cursor: pointer;
125126
transition: border-color 0.15s linear;
126127

127128
-webkit-appearance: none;
@@ -161,17 +162,19 @@ textarea {
161162
.for-checkbox label {
162163
display: block;
163164
padding-bottom: 4px;
165+
cursor: pointer;
164166
}
165167

166168
.for-radio label p,
167169
.for-checkbox label p {
170+
overflow: auto;
168171
color: #000;
169172
font-weight: normal;
170173
}
171174

172-
.for-radio label:hover input:not(:checked) + .input-toggle-component,
173-
.for-checkbox label:hover input:not(:checked) + .input-toggle-component {
174-
border-color: #dfe1e3;
175+
.for-radio label:hover p,
176+
.for-checkbox label:hover p {
177+
color: var(--midgrey);
175178
}
176179

177180
.for-radio input,
@@ -196,11 +199,9 @@ textarea {
196199
background: #f7f7f7;
197200
}
198201

199-
.for-radio p,
200-
.for-checkbox p {
201-
overflow: auto;
202-
color: #b3b2a8;
203-
font-weight: normal;
202+
.for-checkbox label:hover input:not(:checked) + .input-toggle-component,
203+
.for-radio label:hover input:not(:checked) + .input-toggle-component {
204+
border-color: var(--lightgrey);
204205
}
205206

206207
.for-checkbox .input-toggle-component {

0 commit comments

Comments
 (0)