✨ Added "open in your email app" button to increase signup conversion#26198
✨ Added "open in your email app" button to increase signup conversion#26198
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
📝 WalkthroughWalkthroughSniperlinks flag in the portal now treats undefined as enabled ( Changes
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| renderCloseButton() { | ||
| const {site, sniperLinks} = this.context; | ||
| const isSniperLinksEnabled = Boolean(site.labs?.sniperlinks); | ||
| const isSniperLinksEnabled = site.labs?.sniperlinks !== false; |
There was a problem hiding this comment.
Had to change this because GA'd feature flags don't show up in site.labs.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
EvanHahn
force-pushed
the
sniperlinks-ga
branch
from
ec73f07 to
e45a2fc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
EvanHahn
force-pushed
the
sniperlinks-ga
branch
from
e45a2fc to
2f8ca25
Compare
This comment was marked as outdated.
This comment was marked as outdated.
EvanHahn
force-pushed
the
sniperlinks-ga
branch
2 times, most recently
from
dceada7 to
fb77a5d
Compare
| this.portalPopupFrame = page.locator(this.frameSelector); | ||
|
|
||
| this.closeButton = this.portalFrame.getByRole('button', {name: 'Close'}); | ||
| this.closeButton = this.portalFrame.getByTestId('close-popup'); |
There was a problem hiding this comment.
Had to change this because there isn't (necessarily) a button that says "Close" any more.
ref https://linear.app/ghost/project/sniperlink-support-in-portal-5aeb1fec6681 ref #26116 This moves the `sniperlinks` feature flag to GA, releasing it for all.
EvanHahn
force-pushed
the
sniperlinks-ga
branch
from
fb77a5d to
5e4e1fd
Compare
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 21650167700 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 21650167700 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
9larsons
left a comment
9larsons
left a comment
There was a problem hiding this comment.
Interesting. I'll mentally note that site.labs behavior for another time.
…TryGhost#26198) ref https://linear.app/ghost/project/sniperlink-support-in-portal-5aeb1fec6681 ref TryGhost#26116 This moves the `sniperlinks` feature flag to GA, releasing it for all.
2 participants
ref https://linear.app/ghost/project/sniperlink-support-in-portal-5aeb1fec6681
ref #26116
This moves the
sniperlinksfeature flag to GA, releasing it for all.Summary by CodeRabbit