Skip to content

Fixed domain warming when warming has completed#26817

Merged
sam-lord merged 1 commit intomainfrom
domain-warming-fix
Mar 13, 2026
Merged

Fixed domain warming when warming has completed#26817
sam-lord merged 1 commit intomainfrom
domain-warming-fix

Conversation

@sam-lord
Copy link
Contributor

ref INC-258

Got some code for us? Awesome 🎊!

Please take a minute to explain the change you're making:

  • Why are you making it?
  • What does it do?
  • Why is this something Ghost users or developers need?

Please check your PR against these items:

  • I've read and followed the Contributor Guide
  • I've explained my change
  • I've written an automated test to prove my change works

We appreciate your contribution! 🙏

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 650b05d3-0328-4713-8ce3-ab9507ce0cbd

📥 Commits

Reviewing files that changed from the base of the PR and between 1679e24 and 3830882.

📒 Files selected for processing (2)
  • ghost/core/core/server/services/email-service/domain-warming-service.ts
  • ghost/core/test/unit/server/services/email-service/domain-warming-service.test.ts

Walkthrough

The changes modify the domain warming service logic. In the main service file, the getWarmupLimit function was refactored to use conditional logic: it sets limit to Infinity if the computed day is beyond the warm-up period, otherwise it calculates limit through interpolation, then returns the minimum of emailCount and limit. In the test file, two test cases were updated to expect a concrete value of 1000000 instead of Infinity as the result after the warm-up period completes.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description contains only a template checklist without substantive explanation of the change, referenced issue, or rationale for the fix. Provide a meaningful explanation of why this fix was needed, what the issue was, and how the change addresses it, rather than just the template checklist.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: fixing domain warming behavior when the warming period has completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch domain-warming-fix
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@sam-lord sam-lord requested a review from troyciesco March 13, 2026 20:08
@sam-lord sam-lord enabled auto-merge (squash) March 13, 2026 20:15
@sam-lord sam-lord merged commit 8484128 into main Mar 13, 2026
31 checks passed
@sam-lord sam-lord deleted the domain-warming-fix branch March 13, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants