Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR introduces CallToAction and Product plugins/nodes to the Koenig lexical editor. Changes include: adding CallToActionPlugin and ProductPlugin imports to DemoApp.jsx for rendering in the editor UI, exporting ProductPlugin from the public API in index.js, registering CallToActionNode and ProductNode in the email editor nodes configuration, and adding test cases to validate insertion of both new card types via the slash menu. Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ref https://linear.app/ghost/issue/NY-1123 ref TryGhost/Koenig#1754  Co-authored-by: Steve Larson <9larsons@gmail.com>
ref https://linear.app/ghost/issue/NY-1123
Note
Medium Risk
Expands the email editor’s allowed node/plugin set, which can affect card insertion/serialization and email rendering behavior. Changes are localized but touch core editor configuration and e2e coverage.
Overview
Enables Call to action and Product cards in the email editor by adding
CallToActionNode/ProductNodetoEMAIL_EDITOR_NODESand wiringCallToActionPlugin/ProductPlugininto the email editor demo setup.Exports
ProductPluginfrom the package entrypoint and extends the email editor Playwright suite to assert both cards can be inserted via the slash menu.Written by Cursor Bugbot for commit 2c08ac1. This will update automatically on new commits. Configure here.