β¨π Make the Source theme translatable#123
Conversation
β¦to add-i18n-wrapping
|
Caution Review failedPull request was closed or merged during review WalkthroughThis pull request adds internationalization (i18n) support across multiple Ghost theme template files by replacing hard-coded static strings with translation helper function calls. The changes systematically wrap user-facing text in titles, navigation, buttons, form elements, and component labels with the translation helper (t "..."). Approximately 38 lines are modified across 11 template files. No structural changes, conditional logic modifications, or control flow alterations are introducedβonly text localization is updated. Estimated code review effortπ― 2 (Simple) | β±οΈ ~15 minutes π₯ Pre-merge checks | β 3β Passed checks (3 passed)
βοΈ Tip: You can configure your own custom pre-merge checks in the settings. β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@cathysarisky should we help here ? Quite a bit of work had already been done here:https://github.com/SourceTheme-i18n/Source Surely we could reuse it? |
|
Hey @bst1n ! Yes, I will want help soon, including moving over all the great translator work from the SourceThem-i18n project! The architecture is going to be a little bit different. Translation strings are going to live in the themes repo (within the theme-translations folder), so that we can translate once and then have that work available to all official themes. If you'd like to contribute immediately, what would be most helpful would be a comparison between Source and SourceTheme-i18n for anywhere the wrapping is different. If there's anywhere that the wrapping is better in the fork, let's get that over into this repo. I'll announce when we're ready for translations over on the Ghost forum. Very soon, but we need to finalize all the string wrapping before people start translating. |
Comparison: Official Source (post-PR #123) vs SourceTheme-i18n ForkHi @cathysarisky! I did a full comparison of the 1. Official Source wraps strings the fork missed β
2. Fork has a
|
no ref * wrap all the strings! * built tools coming separately.
This PR adds translation wrapping to all strings in Source.
Note
Low Risk
Primarily replaces static strings with translation helpers in templates; low functional risk aside from potential missing/incorrect translation keys affecting displayed text.
Overview
Makes the Source theme translatable by wrapping hard-coded UI copy in Handlebars
{{t}}helpers across templates and partials.This includes the document title pagination suffix, navigation/search/menu labels, membership actions (sign in/subscribe/account/upgrade), feed headings/CTAs (Latest/See all/Read more/Featured/Recommendations), and various accessibility strings (aria-labels and lightbox button titles), plus localized
reading_timesingular/plural formatting.Written by Cursor Bugbot for commit bb1b3b3. This will update automatically on new commits. Configure here.