Removed Loggly transport from @tryghost/logging#650
Conversation
Drops the bunyan-loggly -> node-loggly-bulk -> axios chain, which had become a recurring CVE surface and is no longer maintained upstream. - Removed setLogglyStream(), the loggly option, and the loggly-only match regex branch in log() - Removed the bunyan-loggly dependency - Removed the node-loggly-bulk workspace override (no other consumer); left axios and fast-xml-parser overrides in place - Ported the two serialization tests that incidentally used loggly to stub HttpStream.prototype.write instead Breaking change. Version bump (4.2.1 -> 5.0.0) deferred to 'pnpm ship:major' after merge. Known downstream consumers passing loggly config (Zuul, AppMonitor, Scheduler, UpdateCheck) must pin @tryghost/logging@^4 or migrate to stdout + a log forwarder before adopting ^5. See LOGGLY_MODERNIZATION.md for context.
WalkthroughThis PR removes Loggly transport support from the logging package. The core implementation removes the Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
- Coverage 98.12% 98.11% -0.01%
==========================================
Files 84 84
Lines 2771 2763 -8
Branches 510 507 -3
==========================================
- Hits 2719 2711 -8
Misses 11 11
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
logglytransport, thebunyan-logglydependency, and the loggly-onlymatchregex branch inlog(). Any consumer passingtransports: ['loggly']now hits the existing invalid-transport error.node-loggly-bulkworkspace override (confirmed no other consumer viapnpm why). Leftaxiosandfast-xml-parseroverrides in place — they have non-loggly consumers.serializationtests that incidentally usedBunyan2Logglyto stubHttpStream.prototype.writeinstead.The
bunyan-loggly→node-loggly-bulk→axioschain had become a recurring CVE surface and is unmaintained upstream.Breaking change
Version bump deferred to
pnpm ship:majorafter merge (4.2.1→5.0.0).Known downstream consumers passing
loggly: {...}:TryGhost/ZuulTryGhost/AppMonitorTryGhost/SchedulerTryGhost/UpdateCheckThey must pin
@tryghost/logging@^4or migrate to stdout + a log forwarder before adopting^5.Test plan
pnpm --filter @tryghost/logging test— 40/40 pass, lint cleanpnpm why bunyan-logglyandpnpm why node-loggly-bulkreturn nothingship:major