Skip to content

Cleaned obsolete dependency resolutions from package.json#821

Merged
aileen merged 1 commit into
mainfrom
remove-resolutions
May 27, 2026
Merged

Cleaned obsolete dependency resolutions from package.json#821
aileen merged 1 commit into
mainfrom
remove-resolutions

Conversation

@aileen
Copy link
Copy Markdown
Member

@aileen aileen commented May 27, 2026

Removed stale resolutions entries for node-loggly-bulk, node-loggly-bulk/axios, and handlebars now that the lockfile no longer needs those forced transitive pins. Updated .github/workflows/ci.yml to test the exact minimum supported Node version, 22.13.1, alongside 24, so CI matches the published engines range while keeping yarn.lock focused on live dependencies.

Removed stale `resolutions` entries for `node-loggly-bulk`, `node-loggly-bulk/axios`, and `handlebars` now that the lockfile no longer needs those forced transitive pins. Updated `.github/workflows/ci.yml` to test the exact minimum supported Node version, `22.13.1`, alongside `24`, so CI matches the published `engines` range while keeping `yarn.lock` focused on live dependencies.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f7daaf0e-53ab-4dd9-8024-74bdfc45179f

📥 Commits

Reviewing files that changed from the base of the PR and between 8e8946e and 41ad25f.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • package.json
💤 Files with no reviewable changes (1)
  • package.json

Walkthrough

The PR updates CI and dependency configuration. The Node.js test matrix in the CI workflow is updated to run against a fixed Node version 22.13.1 and Node 24, replacing the previous 22 and 24 entries. Additionally, the package.json file has the top-level resolutions block removed, which previously pinned transitive dependency versions such as handlebars and node-loggly-bulk.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly summarizes the main change: removing obsolete dependency resolutions from package.json, which aligns with the primary file modification.
Description check ✅ Passed The description is directly related to the changeset, explaining both the removal of stale resolutions entries and the CI workflow updates, matching the actual changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-resolutions

Comment @coderabbitai help to get the list of available commands and usage tips.

@aileen aileen merged commit 93f722e into main May 27, 2026
6 checks passed
@aileen aileen deleted the remove-resolutions branch May 27, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant