Skip to content

Test fix - specify electron-mocha version.#1145

Merged
kewde merged 7 commits intoTryGhost:masterfrom
bruce-one:electron-mocha
Apr 27, 2019
Merged

Test fix - specify electron-mocha version.#1145
kewde merged 7 commits intoTryGhost:masterfrom
bruce-one:electron-mocha

Conversation

@bruce-one
Copy link
Copy Markdown
Contributor

electron-mocha dropped support for node 6 in their 8.0.0 release - https://github.com/jprichardson/electron-mocha/blob/master/CHANGELOG.md

(Just triggering the CI for now, apologies for any noise.)

@bruce-one
Copy link
Copy Markdown
Contributor Author

This seems to fix a lot of tests, but Node 11 on OSX seems to be failing with a segfault?

@bruce-one
Copy link
Copy Markdown
Contributor Author

(Actually, that failure kinda looks to be a gremlin? It failed in 10 once, then failed in 11. Will kick it off again.)

@bruce-one
Copy link
Copy Markdown
Contributor Author

On the whole this looks to help a lot, but the sporadic failures do seem to be consistently in the Backup api tests on OSX...

eg:
https://travis-ci.org/mapbox/node-sqlite3/jobs/520594580
https://travis-ci.org/mapbox/node-sqlite3/jobs/520594579
https://travis-ci.org/mapbox/node-sqlite3/jobs/520601166
https://travis-ci.org/mapbox/node-sqlite3/jobs/520698450
https://travis-ci.org/mapbox/node-sqlite3/jobs/520698443
https://travis-ci.org/mapbox/node-sqlite3/jobs/520708877
https://travis-ci.org/mapbox/node-sqlite3/jobs/520708873

All these failures state there's a segfault around the can backup from temp to main test, and they're all on OSX, but not all on one version. Afaict these are the only real test failures?

Not sure if that means there's some not ideal code in that area? I'm running the test suite in a while loop, but no failure yet...

I don't have access to any OSX machines to test on unfortunately.

@kewde
Copy link
Copy Markdown
Collaborator

kewde commented Apr 27, 2019

Thank you @bruce-one!

I've spotted the segmentation fault as well, I'll ping @paulfitz as he's the author of the backup API.
The backup api is still experimental.

@kewde
Copy link
Copy Markdown
Collaborator

kewde commented Apr 27, 2019

Hmmm, oddly enough it sometimes also returns a different error. Not only the segmentation fault error but instead:

86116 Bus error: 10

cfr: https://travis-ci.org/mapbox/node-sqlite3/jobs/521197134#L3926

To the best of my knowledge, this occurs in the test cannot backup to a locked db.

@kewde kewde mentioned this pull request Apr 27, 2019
@kewde
Copy link
Copy Markdown
Collaborator

kewde commented Apr 27, 2019

Merging, as the CI errors are unrelated to this PR.

@kewde kewde merged commit 9a0c292 into TryGhost:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants