[#53] Review and Optimize #5
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements optimization and cleanup of the test suite as part of addressing issue #53. The changes involve removing several test files while maintaining comprehensive test coverage through the existing and enhanced test modules.
- Removes 4 test files (test_uart.c, test_pwm.c, test_i2c.c, test_gpio.c) containing 151-207 lines each
- Updates remaining test files with proper static function declarations and enhanced test coverage
- Adds new test files for time provider and 42 command API functionality
Reviewed Changes
Copilot reviewed 15 out of 20 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_uart.c | Complete removal of UART test suite |
| test/test_transport.c | Add static modifiers to test functions and register missing tests |
| test/test_time.c | New test suite for time provider functionality |
| test/test_simulith.c | Enhanced with additional test cases and static function declarations |
| test/test_pwm.c | Complete removal of PWM test suite |
| test/test_i2c.c | Complete removal of I2C test suite |
| test/test_gpio.c | Complete removal of GPIO test suite |
| test/test_common.c | New test suite for common logging functionality |
| test/test_42.c | New test suite for 42 command API |
| test/CMakeLists.txt | Updated test configuration and added new test executables |
| src/simulith_server.c | Enhanced server with shutdown handling and timeout configuration |
| src/simulith_common.c | Added test-only logging reset functionality |
| include/simulith.h | Added test-only function declaration |
| Makefile | Updated build targets and added coverage reporting |
| CMakeLists.txt | Reorganized test configuration and Unity library setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…e and added codecov action to CI;
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Closes #53.
Closes #55.